Bug 167778

Summary: Assigning ratings in image editor via shortcuts or toolbar not working
Product: [Applications] digikam Reporter: Gandalf Lechner <gandalflechner>
Component: Usability-KeyboardAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 7.5.0
Attachments: patch #1

Description Gandalf Lechner 2008-07-30 21:09:36 UTC 
Version:           0.10.0-beta2 (rev.: 839714) (using 4.1.00 (KDE 4.1.0), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

In the image editor, one can assign ratings 

a) from the context menu given by right click on the pic
b) with the shortcuts Ctrl+X
c) by putting a corresponding entry in the toolbar and clicking it

Here a) works, but b) and c) don't.
Comment 1 Gandalf Lechner 2008-07-30 21:11:45 UTC 
One more thing: In the digikam main window, all three methods work.
Comment 2 Andi Clemens 2008-07-30 21:21:08 UTC 
Can confirm this, I will have a look...
Comment 3 Gandalf Lechner 2008-07-30 21:38:35 UTC 
same bug in the 0.9 version
Comment 4 Andi Clemens 2008-07-30 22:14:17 UTC 
The rating is assigned, but there are some signals missing. Open up the right 
sidebar Caption/Tags, you will see that they are assigned.
I'll fix it...

Andi
Comment 5 Andi Clemens 2008-07-30 22:52:48 UTC 
Created attachment 26510 [details]
patch #1

fixes the assigning of ratings in editorwindow...
Comment 6 caulier.gilles 2008-08-01 15:28:40 UTC 
Andi,

Patch is fine for me.

Gilles
Comment 7 Andi Clemens 2008-08-01 20:41:23 UTC 
Gilles,

maybe we should factorize this too. We call those 6 functions added in the patch (slotAssignRatingNoStar()...) in three places I guess, in main window, lighttable and now image editor. But as a start I will commit this to fix the issue...
Comment 8 Andi Clemens 2008-08-01 20:48:29 UTC 
SVN commit 840766 by aclemens: 

When using shortcuts to assign ratings in image editor, apply them immediately. 

CCBUGS:126871 

 M  +36 -6     imagewindow.cpp   
 M  +7 -0      imagewindow.h   


WebSVN link: http://websvn.kde.org/?view=rev&revision=840766
Comment 9 Andi Clemens 2008-08-01 20:49:16 UTC 
SVN commit 840766 by aclemens: 

When using shortcuts to assign ratings in image editor, apply them immediately. 

CCBUGS:167778 

 M  +36 -6     imagewindow.cpp   
 M  +7 -0      imagewindow.h   


WebSVN link: http://websvn.kde.org/?view=rev&revision=840766
Comment 10 Gandalf Lechner 2008-08-01 21:39:24 UTC 
Works fine here, thanks
Comment 11 Andi Clemens 2008-08-01 22:16:53 UTC 
SVN commit 840783 by aclemens:

backport commit #840766 from KDE4

CCBUGS:167778

 M  +68 -38    imagewindow.cpp  
 M  +9 -2      imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=840783