Bug 167263

Summary:	The OSD does not display the rating of songs.
Product:	[Applications] amarok	Reporter:	Frank Sagurna <fgunni>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hydrogen, stharward
Priority:	LO
Version:	2.0-SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Frank Sagurna 2008-07-22 23:55:35 UTC

Version:            (using KDE 4.0.98)

When changing the rating of a song, osd is displayed.
As i am in the player window, doing a rating for that actual playing song, you dont need an additional osd at that moment. All info is visible at that moment.

Comment 1 Dan Meltzer 2008-08-20 17:34:51 UTC

Right, but as you can change the rating without having amarok open (global shortcuts) It makes sense for the osd to popup.  The real bug is that the osd isn't currently showing the rating...

Comment 2 Frank Sagurna 2008-08-22 16:44:52 UTC

(In reply to comment #1)
> Right, but as you can change the rating without having amarok open (global
> shortcuts) It makes sense for the osd to popup.  The real bug is that the osd
> isn't currently showing the rating...
> 

So best solution would be, to not show osd when amarok is visible, and show it if rating is changed by a shortcut.
Like now its really annoying.

Comment 3 Soren Harward 2008-09-23 16:05:29 UTC

I just committed r863918 to make the ratings show up in the OSD when it's displayed.  The OSD doesn't re-display when the rating is changed in the GUI, so I think this bug can be considered resolved.

Comment 4 Lydia Pintscher 2008-09-23 16:22:51 UTC

Thanks Soren. Closing.