Bug 165937

Summary: pager on a panel is not vertically centered
Product: [Plasma] plasma4 Reporter: Thomas Zander <zander>
Component: widget-pagerAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: aseigo, asraniel, laidig
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Small panel shows how the pager is not vertically centered.
Tall panel shows how the pager only looks at vertical width, cutting off horizontally.

Description Thomas Zander 2008-07-07 13:22:20 UTC 
Version:            (using Devel)

Hi,

I have a xinerama/widescreen setup meaning my pager icons represent a 3290x1200 pixel desktop. There are some layouting issues which makes the pager look less-than-perfect.

The pager does not seem to have a maximum width. So if I have a panel that is 150 pixels tall, the pager calculates the width of each virtual desktop to be pretty wide (because of my 2:1 aspect ratio) and only ~5½ virtual desktops show up before my panel is completely filled.  I suggest to have some sort of maximum size or configuration or something. Maybe just go to 2 rows when each pager-panel gets wider than, say, 120px.

The spacing between the top of the panel and the top of the pager area is constant. So if I have a pager that is 200 pixels tall I have a nice spacing, but if I have a 40 pixels tall panel the 16 pixels spacing at the top makes everything look weird. If my panel gets even smaller the pager doesn't even show the bottom of each virtual desktop anymore...
I would prefer there to be no spacing at all. (like in kde3) see Bug 159742 which for some reason thinks that having a margin is wanted. Not sure why ;)
Comment 1 Thomas Georgiou 2008-07-07 17:30:39 UTC 
Can't you just right click on pager->pager settings and change the number of rows?
Comment 2 Aaron J. Seigo 2008-07-07 22:49:21 UTC 
the margins don't affect click interaction (they are purely visual). 

that said, can you attach some screenshots showing exactly the problem layouts for you? it's easier for people visiting this report, which is about visuals, later if there is something they can look at (versus trying to decipher text only explanations)
Comment 3 Thomas Zander 2008-07-08 10:32:14 UTC 
Created attachment 25924 [details]
Small panel shows how the pager is not vertically centered.
Comment 4 Thomas Zander 2008-07-08 10:33:21 UTC 
Created attachment 25925 [details]
Tall panel shows how the pager only looks at vertical width, cutting off horizontally.
Comment 5 Aaron J. Seigo 2008-11-28 00:49:36 UTC 
the second shot is a different issue unrelated to the pager; the first issue is at least solvable by setting the # of rows, though i agree it should be a wee bit smarter by default.
Comment 6 Jaime Torres 2009-04-25 11:11:20 UTC 
I only have a 1680x1050 px screen, but resizing the pager in a panel, it shows allways a good geometry. (kde 4.2.70).
Comment 7 Jaime Torres 2009-04-25 11:14:12 UTC 
@Thomas, do you still suffer this bug?
Comment 8 Thomas Zander 2009-04-29 09:51:19 UTC 
@Jaime: I compiled kde42 branch and tested, all of the issues are still there.  What version do you think you fixed it?
Comment 9 Aaron J. Seigo 2009-04-29 09:59:44 UTC 
centering is fixed in trunk (4.3), though it will still over-calculate the widths of buttons under the 'right' (wrong? ;) circumstances.
Comment 10 Aaron J. Seigo 2009-04-29 10:00:31 UTC 
vertical centering is fixed in trunk (4.3), though it will still over-calculate the widths of buttons under the 'right' (wrong? ;) circumstances.
Comment 11 Beat Wolf 2009-12-07 12:56:57 UTC 
please retest with a recent kde release, if possible kde 4.4 (beta 1 or later)
Comment 12 Myriam Schweingruber 2012-05-17 13:42:24 UTC 
Closing for lack of feedback. Please feel free to reopen this report if you can still reproduce this with KDE 4.8.3 or later.