Summary: | Conjunctions are not calculated in Japanese locale | ||
---|---|---|---|
Product: | [Applications] kstars | Reporter: | Yukiko Bando <ybando> |
Component: | general | Assignee: | kstars |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Mandriva RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Yukiko Bando
2008-06-28 04:26:35 UTC
SVN commit 825981 by harris: kludgy-but-should-work fix for Bug #165170 (Cunjunctions not calculated for Japanese locale. Thank you for reporting this localization bug...please report any other problems related to localization that you may run into! I did see your second report as well, and I will get a fix ASAP. The problem is that ComboBox->currentText() is translated, but the KSPlanet ctor expects the untranslated name string as a parameter. This solution uses currentIndex() instead, and a switch to determine which planet should be used. The solution is a bit fragile, because the planets are now assumed to appear in a particular order in the combobox. I am planning to implement a better solution in the unfrozen branch, so please don't port these changes to unfrozen or summer; wait for the unfrozen fix. CCMAIL: kstars-devel@kde.org BUG: 165170 M +43 -19 conjunctions.cpp M +3 -7 conjunctions.h WebSVN link: http://websvn.kde.org/?view=rev&revision=825981 SVN commit 826351 by harris: Better fix for bug #165170. Now the order of items in the planet comboboxes is hard-coded in conjunctions.cpp, using a new PLANET enum I added to KSPlanetBase. So it's not possible for the order to be wrong. I also added a convenience function 'static KSPlanetBase* KSPlanetBase::createPlanet(int)', so you can simply call: KSPlanetBase::createPlanet(VENUS), rather than using the KSPlanet ctor, and using the planet's name to determine which planet gets created. There is also a new KSPlanet(int) ctor that does essentially the same thing. Note: this commit won't be merged into trunk until after 4.1 is released. CCMAIL: kstars-devel@kde.org CCBUG: 165170 M +31 -1 ksplanet.cpp M +33 -26 ksplanet.h [POSSIBLY UNSAFE: system] M +40 -6 ksplanetbase.cpp M +11 -6 ksplanetbase.h M +21 -19 tools/conjunctions.cpp M +2 -7 tools/conjunctions.h M +0 -100 tools/conjunctions.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=826351 |