Bug 164460

Summary:	"Invalid Proxy Setting" message while the setting is just fine
Product:	[Applications] systemsettings	Reporter:	Patrick <mail>
Component:	kcm_proxy	Assignee:	Dawit Alemayehu <adawit>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, andresbajotierra, grundleborg
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.8

Description Patrick 2008-06-19 18:09:53 UTC

Version:            (using Devel)
Installed from:    Compiled sources

Screenshot: http://p173.de/s/1213891153.png

Another problem (bug number two) with this dialogue: once you press the OK button on the error message window, the Manual Proxy Configuration dialog closes. So instead of being able to try to correct the mistake (where is none, that's bug number one), I loose everything, and have to start from scratch again by clicking the Setup... button next to 'Manually specify the proxy settings' again.

Comment 1 Dario Andres 2009-01-06 15:15:57 UTC

Can you still reproduce this bug with a recent KDE (4.1.3 / 4.2beta2 / 4.2svn) ? Thanks :)
If you do, can you post an image directly in the report using the "Add an Attachment" option

Comment 2 Patrick 2009-01-08 15:48:38 UTC

(In reply to comment #1)
> Can you still reproduce this bug with a recent KDE (4.1.3 / 4.2beta2 / 4.2svn)
> ? Thanks :)
> If you do, can you post an image directly in the report using the "Add an
> Attachment" option

Darío, thanks for the reminder. The major problem has been fixed (the dialogue now accepts the valid entries I tested just now), but the minor usability problem still persists: When the user enters invalid values and acknowledges the error message by clicking the OK button, the parent dialogue with the settings also gets closed, and the user must start from zero.

Sorry for the link breakage, I restored the image and the link now works again.

Comment 3 Dawit Alemayehu 2011-04-25 22:13:08 UTC

The upcoming proxy configuration overhaul will make this a moot point because the manual proxy configuration won't be on a separate dialog. :)

Comment 4 Dawit Alemayehu 2011-10-20 06:16:29 UTC

Git commit f90f318f2162df18a08b889d24ae8bbeab3b834c by Dawit Alemayehu.
Committed on 01/08/2011 at 07:44.
Pushed by adawit into branch 'master'.

Rewrote the proxy configuration dialog to include missing SOCKS
proxy entry and make it much simpler to use.

BUG:82352
BUG:115704
BUG:139789
BUG:147340
BUG:164460
BUG:189019
BUG:190149
BUG:190901
BUG:205594
BUG:258196
BUG:283226
FIXED-IN:4.8

REVIEW: 102802

GUI:  Proxy configuration dialog rewrite.

M  +0    -5    konqueror/settings/kio/CMakeLists.txt
D  +0    -251  konqueror/settings/kio/envvarproxy.ui
D  +0    -310  konqueror/settings/kio/kenvvarproxydlg.cpp
D  +0    -71   konqueror/settings/kio/kenvvarproxydlg.h
D  +0    -496  konqueror/settings/kio/kmanualproxydlg.cpp
D  +0    -86   konqueror/settings/kio/kmanualproxydlg.h
M  +410  -215  konqueror/settings/kio/kproxydlg.cpp
M  +30   -18   konqueror/settings/kio/kproxydlg.h
M  +833  -248  konqueror/settings/kio/kproxydlg.ui
D  +0    -79   konqueror/settings/kio/kproxydlgbase.cpp
D  +0    -69   konqueror/settings/kio/kproxydlgbase.h
M  +77   -88   konqueror/settings/kio/ksaveioconfig.cpp
M  +28   -32   konqueror/settings/kio/ksaveioconfig.h
D  +0    -291  konqueror/settings/kio/manualproxy.ui

http://commits.kde.org/kde-baseapps/f90f318f2162df18a08b889d24ae8bbeab3b834c