| Summary: | kget download from php with bad name | ||
|---|---|---|---|
| Product: | [Applications] kget | Reporter: | giuseppe <metrobotte> |
| Component: | general | Assignee: | KGet authors <kget> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
giuseppe
2008-06-19 00:51:21 UTC
This bug needs some work, namely KIO(or any other transfer-plugin) should have the ability to change the filename according to the server side if the user don't supply one(only assign the directory). An directoryOnly option may be add to KGet::createTransfer() like KGet::createTransfer(KUrl srcUrl, KUrl destUrl, const QString& groupName, bool start, bool directoryOnly=false). Then the plugin can determine the filename itself. Notice that, if we do so, the way to check duplicate transfer in m_transferTreeModel also need to be modified to check duplication only when directoryOnly==false. Well, not imo, we need to know how the Filename will when initializing the NewTransferDialog, cause there, the user _can_ change the filename... Lukas PS: I have no clue how to implement this, but probably a TransferFactory::suggestedFilename(const KUrl &url); is necessary? I just reproduce the bug, if I type the filename 'system-status.tar.bz2' in the Destination input, it's fine. But If I only specify the directory there, KGet will download it as download.inc.php. But quite often, user won't bother specify the filename, or they simply don't know, the server will always return a filename anyway. I've seen this behavior in some popular downloaders. Kget3 works fine..without specify the name. Am Donnerstag, 19. Juni 2008 schrieb giuseppe:
> ------- Kget3 works fine..without specify the name.
Yes. Konqueror passed the server-specified filename as an additional parameter
to kget. (You get the filename from KIO's metadata IIRC).
Actually we have that passing from Konqueror as well... I think the reporter uses another Browser and/or pasts directly to the NewTransferDialog... Lukas Solved on konqueor 4.00.84 |