Bug 158681

Summary: Remove attachment does not work for some mime structures
Product: [Applications] kmail Reporter: Martin Koller <kollix>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.9.9   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Martin Koller 2008-03-02 15:30:43 UTC
Version:           1.9.9 (using 3.5.8 "release 44.1" , openSUSE )
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.22.17-0.1-default

Trying to use "delete attachment" from a mail (mail is inside local maildir mailbox) brings up a dialog "Deleting an attachment might invalidate any digital signature on this message." but clicking "OK" only closes the dialog. The mail stays unchanged and still has its attachment.
Some message headers:

MIME-Version: 1.0
Content-Type: multipart/mixed;
  boundary="----_=_NextPart_001_01C87B30.4832E200"


This is a multi-part message in MIME format.

------_=_NextPart_001_01C87B30.4832E200
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_002_01C87B30.4832E200"


------_=_NextPart_002_01C87B30.4832E200
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Dear All,
...


------_=_NextPart_002_01C87B30.4832E200
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

...


------_=_NextPart_002_01C87B30.4832E200--

------_=_NextPart_001_01C87B30.4832E200
Content-Type: application/vnd.ms-powerpoint;
	name="Demo.ppt"
Content-Transfer-Encoding: base64
Content-Description: Demo.ppt
Content-Disposition: attachment;
	filename="Demo.ppt"

...
Comment 1 Thomas McGuire 2008-03-02 23:13:27 UTC
Yes, confirmed. Happens only for some mime structures.
Comment 2 Volker Krause 2008-03-07 20:29:49 UTC
SVN commit 783307 by vkrause:

BUG: 158854
BUG: 158681 

Merged revisions 783303 via svnmerge from 
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim

........
  r783303 | vkrause | 2008-03-07 20:15:37 +0100 (Fri, 07 Mar 2008) | 5 lines
  
  Some mimelib voodoo to make attachment modification/deletion work with
  all kinds of multipart sturctures.
  
  Kolab issue 1770
........


 _M            . (directory)  
 M  +44 -10    kmail/kmcommands.cpp  
 M  +4 -0      kmail/kmcommands.h  
 M  +0 -6      kmail/kmmessage.cpp  
 M  +0 -3      kmail/kmmessage.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=783307
Comment 3 alancio 2008-03-07 20:45:55 UTC
This is a the same bug as in 158854.

Its the case when there is only one attachment left.