Bug 157646

Summary:	Highlight search/quick filter results in matching posts
Product:	[Applications] akregator	Reporter:	Tap
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	REPORTED ---
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch to highlight filter results inside article

Description Tap 2008-02-11 03:23:14 UTC

Version:            (using KDE 3.5.8)
Installed from:    Compiled From Sources
Compiler:          gcc 4.1.2 i486-slackware-linux 
OS:                Linux

It would be nice to have Akregator highlight matching terms in articles that show up as a result of the 'Quick Filter' feature. So, I coded up this patch. It may need some help if colors should adapt to the user's color scheme rather than the highlight color being hardcoded, but otherwise seems to work, at least with the normal view mode.

Comment 1 Tap 2008-02-11 03:24:11 UTC

Created attachment 23528 [details]
Patch to highlight filter results inside article

Comment 2 Tap 2008-02-11 14:19:50 UTC

This patch does mess up the initial Akregator welcome screen display. (It appears blank with the patch applied.) I'm not sure why.

Comment 3 Frank Osterfeld 2008-02-12 21:07:01 UTC

To have such a feature is a good idea - I won't include it in 3.5.x though, it should be done in trunk. 

Some remark: I would prefer to leave the SearchBar out of articleviewer and pass a list of strings to hightlight to the articleviewer instead.

Comment 4 Tap 2008-02-12 21:25:46 UTC

I am not sure where that list should come from, but I agree that having the searchbar in there is a hack. I just wasn't sure how to do it better (in the amount of time I spent), not having a very strong grasp on Qt/KDE or Akregator's design.

I'm sure you're right about 3.5.x, but it is a feature I've wanted for a while; it's annoying to type in a filter and then have to retype it in the Find dialog to find it within an article.

Comment 5 Justin Zobel 2021-03-09 04:12:15 UTC

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.