Bug 156799

Summary:	Check return codes everywhere
Product:	kdemultimedia	Reporter:	Markus Elfring <Markus.Elfring>
Component:	general	Assignee:	Multimedia Developers <kde-multimedia>
Status:	CLOSED NOT A BUG
Severity:	normal	CC:	finex
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:

Description Markus Elfring 2008-01-27 19:15:33 UTC

Version:            (using KDE 4.0.0)
Installed from:    SuSE RPMs

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "pthread_mutex_lock" like in the function "cdda_fct_read" and from "strdup" in the function "wm_cd_init"?
http://websvn.kde.org/trunk/KDE/kdemultimedia/libkcompactdisc/wmlib/cdda.c?revision=756952&view=markup
http://websvn.kde.org/trunk/KDE/kdemultimedia/libkcompactdisc/wmlib/cdrom.c?revision=756913&view=markup

Comment 1 FiNeX 2008-11-19 18:24:04 UTC

Hi, this type of technical discussion should be done on various mailing lists where developers can elaborate and choose how to manage this development hints.

Thanks for your suggestions!

Regards.