Bug 155912

Summary: fifteen puzzle splits up custom images incorrectly
Product: [Plasma] plasma4 Reporter: Anthony Bryant <antjbryant>
Component: widget-fifteenpuzzleAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: screenshot of bug in fifteen puzzle
patch against revision 763629

Description Anthony Bryant 2008-01-16 14:49:24 UTC 
Version:            (using KDE 4.0.0)
Installed from:    Ubuntu Packages
OS:                Linux

When the fifteen puzzle is set to use a custom image, using "split image into puzzle pieces" in the config, the top right corner of the image is used for the blank tile, instead of the bottom right tile where it should be.

This can be reproduced by solving the puzzle and then setting it to use a custom image. As it is at the moment, it is impossible to solve the puzzle so that the image looks right.
Comment 1 Anthony Bryant 2008-01-16 14:53:18 UTC 
Created attachment 23075 [details]
screenshot of bug in fifteen puzzle

Here is a screenshot showing a solved puzzle with a custom image.
Comment 2 Anthony Bryant 2008-01-20 01:12:47 UTC 
Created attachment 23148 [details]
patch against revision 763629

The loop was changing to the next row of the image too early, so only a bit of
logic needed changing.
Comment 3 Jesper Thomschütz 2008-01-20 01:15:25 UTC 
Seems good to me, feel free to apply the patch.
Comment 4 Anthony Bryant 2008-01-20 01:27:54 UTC 
I would if I had an svn account... can someone who does apply it please?
Comment 5 Jesper Thomschütz 2008-01-20 11:26:55 UTC 
Whoops, sorry! Revision:763726 is your patch.

Thanks Anthony :)
Comment 6 Anne-Marie Mahfouf 2008-01-20 12:24:18 UTC 
Closing as Jesper applied Anthony's patch 
http://lists.kde.org/?l=kde-commits&m=120082460610962&w=2
and it's working properly now.