Summary: | Allow users using "visual bell" as in KDE3 konsole | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Enrico <enricoab> |
Component: | general | Assignee: | Robert Knight <robertknight> |
Status: | RESOLVED DUPLICATE | ||
Severity: | wishlist | CC: | adaptee, jcrockett70 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Konsole notification patch |
Description
Enrico
2008-01-13 11:14:36 UTC
> Changes in the Settings > Configure notifications dialog have no effect. Confirmed. That looks like a bug rather than a lack of configuration options. I get a proper sound effect when triggering the bell, but making changes has no effect. KDE 3 provided several options for the bell mode: - System Bell - No Bell - System notification The first of those sounds horrible and the second can be achieved by turning off sound and other effects in the 'Configure Notifications' dialog. This means the one option which is in KDE 3 and missing from KDE 4 is the "Visual Bell" option. > which is currently missing from the dialog It is missing from the dialog because it does not work. Created attachment 22998 [details]
Konsole notification patch
The attached patch would allow to choose between system bell, system
notification, visible bell and no bell. At least it works for me. However, it
makes the Settings dialog larger. If you decide to adopt this approach, it may
be worth to move some options away from the Advanced Tab.
> The attached patch would allow to choose between system bell, system
> notification, visible bell and no bell. At least it works for me.
Before you sit down and right patches lets discuss what options are actually necessary first. As I said before, the menu in KDE 3 had four options, three of which could be replaced by one.
That means the only remaining question is whether the "visual bell" is useful?
> Before you sit down and right patches lets discuss what options are actually necessary first
Sorry, I meant "Before you sit down and write" patches.
I personally use the visual bell, so I would be sorry of seeing it go. Anyway, I guess somebody with no sound card may like to have at least the visual bell or the system bell. > Anyway, I guess somebody with no sound card may like to have at least the visual bell or the system bell.
Okay. In that case the only option needed is a checkbox to select whether the visual bell should be shown or not. eg ("Flash display when bell occurs in terminal.")
I think there is room for that on the Advanced page, although in future some re-arrangement might be required - for example, moving the cursor options into a separate dialog.
Fair enough. Should I modify my patch or should I leave everything to you? SVN commit 760960 "Backport #760957. Show terminal size in a label in the center of the display when resizing the terminal. Change the default bell mode to 'System Notification'. Fixed Settings -> Configure Notifications changes having no effect." I use this functionality a lot. I have multiple tabs with different tasks running, and I used to use this visual bell to notify when a task is ready for further input from me. KDE4 konsole doesn't have this and what they do have does not correlate to a specific tab, which is what I need. The "system beep" is requested and tracked in bug 177861, so rename this reprot to track "visual bell" only. Git commit 2ba24db12c80fb834d139a69f7d15d22b5c1b40f by Jekyll Wu. Committed on 17/02/2012 at 10:26. Pushed by jekyllwu into branch 'master'. Add per-profile option 'BellMode' for choosing the type of bell There are no GUI elements for controlling that option, so it is a hidden option at the moment. To configure this option manually, put following lines into some konsole profile under ~/.kde4/share/apps/konsole/ : [Terminal Features] BellMode=N Where N could be 0 for system beep, 1 for system notification and 2 for visual bell. That mapping might change before next major release. Related: bug 177861 REVIEW: 104013 M +2 -0 src/Profile.cpp M +12 -0 src/Profile.h M +3 -0 src/ViewManager.cpp http://commits.kde.org/konsole/2ba24db12c80fb834d139a69f7d15d22b5c1b40f Mark this as duplicate of bug 177861, since fixing one would also fix the other in the meantime. *** This bug has been marked as a duplicate of bug 177861 *** |