Bug 155533

Summary:	Undocked DockWidget windows show up in taskbar
Product:	[Plasma] plasma4	Reporter:	David Benjamin <davidben>
Component:	widget-taskbar	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	finex, l.lunak
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	A screenshot of the places icon in the taskbar

Description David Benjamin 2008-01-12 17:13:59 UTC

Version:            (using KDE KDE 4.0.0)
Installed from:    Ubuntu Packages
OS:                Linux

Steps to Reproduce:
1. Open Dolphin.
2. Undock Places panel

Expected Behavior:
The places panel does not show up in the taskbar.

Actual Behavior:
The panel shows up in the taskbar under the name "&Panel".


The window does not appear in the taskbar under GNOME, so I expect there's some hint (skip window list?) that the task bar is ignoring.

Comment 1 Alex Merry 2008-01-12 18:16:14 UTC

I think we should either be watching for _NET_WM_WINDOW_TYPE_UTILITY in _NET_WM_WINDOW_TYPE, or we should look for WM_TRANSIENT_FOR being set.

However, this also appears in KDE 3, so maybe Dolphin is at fault for not setting the correct hints.

Lubos?  Some clue, please?

Comment 2 Aaron J. Seigo 2008-01-13 01:10:10 UTC

while i see this behaviour in kde3, i am not seeing it in my kde4 build. the kde4 taskbar plasmoid does not show the places sidebar when removed. so i don't think this is an issue with the taskbar.

Comment 3 Alex Merry 2008-01-13 12:20:33 UTC

Created attachment 22990 [details]
A screenshot of the places icon in the taskbar

This screenshot shows what I get.  As soon as I change window, the places
window disappears, and the taskbar entry with it.

Possibly it's just that Dolphin is at fault in not setting a _NET_WM_STATE to
_NET_WM_STATE_SKIP_TASKBAR.  I don't know, which is why I wanted Lubos' input.

Comment 4 FiNeX 2008-01-13 13:28:42 UTC

On revision 760683, the "&Places" item in the taskbar appears only if dolphin has the focus.

Comment 5 Lubos Lunak 2008-01-14 17:31:01 UTC

Dolphin should not mess with _NET_WM_STATE_SKIP_TASKBAR. In this case I think it is up to the taskbar to decide what it wants to show. You can not show any utility windows in the taskbar (although perhaps some people might want that), you can not show any windows that have WM_TRANSIENT_FOR set for other window that has taskbar entry, or even something else if you have a better idea.

PS: The KDE3 difference may be in kwin's option that controls whether utility windows are hidden for inactive windows.

Comment 6 David Benjamin 2008-01-14 17:34:35 UTC

Hrm, if it is opted to have the window visible in the taskbar, it would probably be good to change the window title from "&Places" to "Places" or maybe even "Dolphin - Places", otherwise it looks kind of weird.

(And while we're at it, it could use an icon. :-D )

Comment 7 David Benjamin 2008-03-23 00:57:53 UTC

Incidentally, what is the point of the &Places anyway? Pressing Alt-P doesn't seem to focus on anything.

Interestingly, the window does not appear in the taskbar when a different window manager (e.g. metacity) with Plasma still running, nor does it appear if one switches to kwin after the widget is undocked. It only appears if it is undocked while kwin is running.

Comment 8 Aaron J. Seigo 2008-07-07 02:20:14 UTC

SVN commit 828929 by aseigo:

* don't show utility windows
* m_tasks -> m_geometryTasks as that communicates what that member is for a lot clearer
BUG:155533


 M  +26 -4     tasks.cpp  
 M  +1 -1      tasks.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=828929