| Summary: | extraxt all files doesn't work | ||
|---|---|---|---|
| Product: | [Applications] ark | Reporter: | sts |
| Component: | general | Assignee: | Harald Hvaal <metellius> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | michal, rakuco |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
if going to extract all, passes an empty list to extract
make karchive extract all when file list is empty make bk extract all when file list is empty |
||
|
Description
sts
2008-01-07 11:38:13 UTC
Because you've selected only one file. On Ark in KDE4.0.0 it doesn't extract anything unless it is selected. This is definitely a bug. When the user chooses to extract all files, Ark should extract all files, not just the selected. Moreover when no file is selected, the user should be given the option to extract all files. Created attachment 22973 [details]
if going to extract all, passes an empty list to extract
Extract all was not working because it always passed a list with the selected
files to extraction.
Instead of passing a list with all files, passing an empty list gives the
chance to the backend better handle the action.
Created attachment 22974 [details]
make karchive extract all when file list is empty
Updates the karchive plugin.
Created attachment 22975 [details]
make bk extract all when file list is empty
Updates the bk plugin.
ping, the same with 4.0.84 I got the same on 2.9.999 Version 2.10.999 Sous KDE 4.1.00 (KDE 4.1.0) KDE 4.1.0 is no released and the problem stays. Is someone doing something to correct this ? I think it should be considered as an important bug (makes Ark unusable while this soft is one of the most used under KDE...) Fixed with svn commit 849401.
Did not appear here automatically for some reason, maybe it's the new bugzilla.
diff --git a/part/part.cpp b/part/part.cpp
index 6f8a194..087a837 100644
--- a/part/part.cpp
+++ b/part/part.cpp
@@ -458,7 +458,14 @@ void Part::slotExtractFiles()
}
else destinationDirectory =
dialog.destinationDirectory().path();
- QList<QVariant> files = selectedFilesWithParents();
+ QList<QVariant> files;
+
+ //if the user has chosen to extract only selected entries,
fetch these
+ //from the listview
+ if (!dialog.extractAllFiles()) {
+ files = selectedFilesWithParents();
+ }
+
kDebug( 1601 ) << "Selected " << files;
ExtractJob *job = m_model->extractFiles( files,
destinationDirectory, dialog.preservePaths(
m_jobTracker->registerJob( job );
|