Bug 154082

Summary:	ctrl ++ zoom Keyboard shortcut for text resize changed [usability]
Product:	[Applications] konqueror	Reporter:	Marko Burjek <email4marko>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jonas.vejlin, mss
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	patch to fix the issue

Description Marko Burjek 2007-12-15 11:15:20 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

In KDE 3.5.7 keyboard shortcut for changing text size in web pages is Ctrl + +, and Ctrl + -. In KDE 4 (3.97.1) it is Ctrl + = and Ctrl + -. Ctrl + = Requires 3 buttons to be preset on Slovenian Keyboard. (Ctrl and Shift and 0/=). Because = is on number part of the keyboard and shares a button with 0. Is this change only temporary or will it stay that way?

Don't fix it if it ain't broken ;)

I wish that keyboard shortcut would stay as it was.(Ctrl++) It is also more intuitive IMHO.

Comment 1 A. Spehr 2008-06-28 02:40:30 UTC

*** Bug 163092 has been marked as a duplicate of this bug. ***

Comment 2 A. Spehr 2008-06-28 02:53:37 UTC

I guess this is wishlist, and I can't test it at the moment, but wow was seele horrified when she heard...

Comment 3 David Mrowietz 2008-07-07 17:22:28 UTC

i can confirm this with a german keyboard layout(KDE 4.0.85).

Comment 4 Malte S. Stretz 2008-07-15 16:01:56 UTC

Just stumbled upon this as well.  The following patch would fix this:

Index: kdelibs/khtml/khtml_part.cpp
===================================================================
--- kdelibs/khtml/khtml_part.cpp        (revision 831857)
+++ kdelibs/khtml/khtml_part.cpp        (working copy)
@@ -345,7 +345,7 @@
   if ( prof == BrowserViewGUI ) {
       d->m_paIncZoomFactor = new KHTMLZoomFactorAction( this, true, "format-font-size-more", i18n( "Enlarge Font" ), this );
       actionCollection()->addAction( "incFontSizes", d->m_paIncZoomFactor );
-      d->m_paIncZoomFactor->setShortcut(KShortcut("CTRL++;CTRL+="));
+      d->m_paIncZoomFactor->setShortcut( QKeySequence(Qt::CTRL + Qt::Key_Plus) );
       connect(d->m_paIncZoomFactor, SIGNAL(triggered(bool)), SLOT( slotIncFontSizeFast() ));
       d->m_paIncZoomFactor->setWhatsThis( i18n( "Enlarge Font<br /><br />"
                                                 "Make the font in this window bigger. "
===================================================================

But:  The previous code should be fine as well, because
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKShortcut.html#80612bcd54ff18ccf458253d45b8488e
says "The format of description is the same as used in QKeySequence::fromString(const QString&). Up to two key sequences separated by a semicolon followed by a space "; " may be given."

So the bug might be either in KShortcut or even QKeySequence (this is Qt 4.4.0), I guess one of them thinks the shortcut CTRL++ is broken or something.

Comment 5 Malte S. Stretz 2008-07-15 16:37:11 UTC

Created attachment 26149 [details]
patch to fix the issue

duh, no.  this patch will fix it.  KShortcut::KShortcut(QString) has a
dangerous api...

Comment 6 David Faure 2008-07-16 23:33:58 UTC

SVN commit 833481 by dfaure:

Apply patch by Malte S. Stretz (moonflux) to fix (workaround) "Ctrl +" not working.
Approved by Maksim.
BUG: 154082


 M  +3 -1      khtml_part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=833481