Summary: | renaming filename in konqueror when broken symlink with new name exists does not give rename/overwrite dialog | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Shriramana Sharma <samjnaa> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | faure |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Shriramana Sharma
2007-11-04 16:49:49 UTC
Confirmed in konqueror 4 trunk r813735 I forgot to say that only the following cases remain: * foo and goo files * foo and goo directories SVN commit 925561 by dfaure: Re-testing #151851 (rename file to name of existing symlink) I found that it worked (I do get the overwrite dialog), but after overwriting the icon wouldn't be updated correctly. KDirLister was emitting the renaming before the deletion, which would make kdirmodel lose the new data. And when writing the unittest for this I discovered another bug: KDirLister didn't process correctly the KDirWatch signal emitted when an old file is re-created again. BUG: 151851 M +44 -27 kio/kdirlister.cpp M +1 -1 kio/kdirlister_p.h M +49 -0 tests/kdirlistertest.cpp M +1 -0 tests/kdirlistertest.h WebSVN link: http://websvn.kde.org/?view=rev&revision=925561 Ah closed it too early. Overwriting the symlink with a directory still breaks. Note that the type of "foo" doesn't matter, the test matrix is - overwriting a symlink [or a file] with a file - overwriting a symlink [or a file] with a directory - and the case of overwriting a directory with a file, which can't work, but needs to be handled correctly. SVN commit 927192 by dfaure: Fix non-working (and/or crashing) overwriting of a file (or symlink) with a directory. CCBUG: 151851 M +10 -11 kio/copyjob.cpp M +22 -20 kio/kdirlister.cpp M +17 -2 kio/kdirmodel.cpp M +38 -0 tests/kdirmodeltest.cpp M +2 -1 tests/kdirmodeltest.h M +54 -0 tests/kiotesthelper.h WebSVN link: http://websvn.kde.org/?view=rev&revision=927192 SVN commit 927501 by dfaure: Don't offer to Overwrite "dir" with "file" when renaming "file" to "dir", it won't do it, offer the rename dialog for choosing another name. BUG: 151851 M +11 -3 copyjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=927501 |