Bug 151697

Summary:	Arrow not drawn in toolbars that have dropdown menus
Product:	[Plasma] Oxygen	Reporter:	Thomas McGuire <mcguire>
Component:	style	Assignee:	Camilla Boemann <cbo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	maksim, wstephenson
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Change to permit drawing these, in KStyle. Use the support in oxygen

Description Thomas McGuire 2007-11-01 15:28:26 UTC

Version:            (using KDE KDE 3.94.0)
Installed from:    Compiled From Sources

The little arrow, which indicates that a toolbar button is really a combobox, is not drawn at all in KDE4.

One example is the "Options" button in the toolbar of the open file dialog, another example is the "Reply" toolbar button in KMail.

Without these arrows, it is not possible for new users to discover that a button has extended functionality.

Comment 1 Aaron J. Seigo 2007-11-01 19:30:39 UTC

it is shown on buttons that both a menu and a click-and-hold menu; i'm not sure what the value is in showing the drop down menu on pure-menu buttons, however.

Comment 2 Thomas McGuire 2007-11-03 17:15:02 UTC

>it is shown on buttons that both a menu and a click-and-hold menu; i'm not sure what the value is in showing the drop down menu on pure-menu buttons, however. 

I don't know if I parsed your sentence correctly, but here are the reasons I want the arrow back:

- In KMail, the 'Reply' button works with a single click (which will reply normally), and shows a menu if you hold down the button a bit longer. The arrow is clearly needed here, as nobody tries to hold buttons longer just to see if they might have an additional menu

- On the file open dialog, it would still be nice so that the user can see that this button has more actions than one without having to hover over it to see the tooltip.

Comment 3 Thomas McGuire 2008-05-29 21:16:51 UTC

Reassigning this bug to Oxygen.
The Plastique style now suddenly works fine, but Oxygen still does not draw those arrows.

Comment 4 Maksim Orlovich 2008-05-30 18:55:48 UTC

KStyle follows what plastique/QCommonStyle used to do, but may be that changed... Will take a look..

Comment 5 Maksim Orlovich 2008-05-30 22:09:49 UTC

Created attachment 25018 [details]
Change to permit drawing these, in KStyle.

Comment 6 Maksim Orlovich 2008-05-30 22:10:26 UTC

Created attachment 25019 [details]
Use the support in oxygen

Shame Oxygen duplicates quite some metrics code...

Comment 7 Maksim Orlovich 2008-05-30 22:22:10 UTC

SVN commit 814598 by orlovich:

Add support for drawing inline arrows, like Qt4.4 does.
CCBUG:151697



 M  +17 -0     kstyle.cpp  
 M  +15 -2     kstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=814598

Comment 8 Maksim Orlovich 2008-05-30 22:23:15 UTC

SVN commit 814599 by orlovich:

Enable drawing of inline arrows. OK'd by boemann.
You Oxygen folks might want to tweak it somewhat, of course.
BUG:151697


 M  +5 -0      oxygen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=814599