Bug 150023

Summary: webinterface plugin 404 error page
Product: [Applications] ktorrent Reporter: Fernando Muñoz <munozferna>
Component: generalAssignee: Joris Guisson <joris.guisson>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:

Description Fernando Muñoz 2007-09-20 05:29:07 UTC 
Version:            (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

There is a typo in the webinterface plugin httpserver, it doesn't close the body tag correctly.

http://websvn.kde.org/branches/extragear/kde3/network/ktorrent/plugins/webinterface/httpserver.cpp?view=markup

#define HTTP_404_ERROR "<html><head><title>404 Not Found</title></head><body>The requested file $FILE was not found !</body</html>"

Besides this, I think that it should encode the path before replacing the '$FILE' to avoid cross site scripting within ktorrent internal web server.
Comment 1 Joris Guisson 2007-09-20 18:33:07 UTC 
SVN commit 714793 by guisson:

Make sure body tag is OK in 404 and 500 error defines.

BUG: 150023



 M  +2 -3      httpclienthandler.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=714793