Summary: | Smart Playlist does not load tracks with a rating >= 4.5 | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Amos Kariuki <amoskahiga> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hessijames |
Priority: | NOR | ||
Version: | 1.4.7 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Amos Kariuki
2007-08-17 03:09:12 UTC
SVN commit 707941 by mkossick: fixed off-by-one error BUG:148916 M +2 -4 smartplaylisteditor.h --- branches/stable/extragear/multimedia/amarok/src/smartplaylisteditor.h #707940:707941 @@ -133,16 +133,14 @@ inline int CriteriaEditor::indexToRating( int index ) { - if ( index <= 9 && index >= 1 ) return index + 1; - if ( index == 0 ) return index; + if ( index <= 10 && index >= 0 ) return index; return -1; } inline int CriteriaEditor::ratingToIndex( int rating ) { - if ( rating <= 10 && rating >= 2 ) return rating - 1; - if ( rating == 0 ) return rating; + if ( rating <= 10 && rating >= 0 ) return rating; return -1; } *** Bug 150345 has been marked as a duplicate of this bug. *** |