Bug 147671

Summary: Portability problem in configure script
Product: [Applications] digikam Reporter: Thomas Klausner <tk>
Component: Portability-CmakeAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: NetBSD pkgsrc   
OS: NetBSD   
Latest Commit: Version Fixed In: 0.9.3
Attachments: Patch fixing the problem.

Description Thomas Klausner 2007-07-08 11:00:28 UTC
Version:           0.9.2 (using KDE KDE 3.5.7)
Installed from:    NetBSD pkgsrc
OS:                NetBSD

digikam-0.9.2's configure script uses the unportable bash "=="
comparison operator for test(1). It is not supported by most other
shells or even test(1) from GNU coreutils. Please use "="
instead. I'll attach a patch.
Comment 1 Thomas Klausner 2007-07-08 11:00:55 UTC
Created attachment 21086 [details]
Patch fixing the problem.
Comment 2 caulier.gilles 2007-07-10 22:49:26 UTC
SVN commit 686229 by cgilles:

fix automake syntax to be portable under NETBSD
BUG: 147671


 M  +1 -1      configure.in.in  


--- branches/extragear/kde3/graphics/digikam/configure.in.in #686228:686229
@@ -330,7 +330,7 @@
  [enable_nfs_hack=no]
 )
 
-if test "x$enable_nfs_hack" == "xyes"; then
+if test "x$enable_nfs_hack" = "xyes"; then
    AC_DEFINE(NFS_HACK, 1, [NFS hack enabled])
    AC_MSG_NOTICE([NFS hack enabled. Make sure you know what you are doing])
 fi