Summary: | Deleting Gadu-Gadu (multi)contacts witch had multiplied themselves causes Kopete to crash | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | Michał ,,KNT'' Gorycki <knt> |
Component: | Gadu-Gadu Plugin | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde, lamarque, mieszkoslusarczyk, rainy, shade.poczta |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.6.2 | |
Attachments: | Path for gaducontactlist.cpp |
Description
Michał ,,KNT'' Gorycki
2007-07-02 00:00:09 UTC
Not sure the problem is in Gadu, since there's some bits of Jabber in the backtrace, but Gadu is probably the best place to start. I could successfuly delete those clones with kopete svn trunk r836553. No crash or something, allthough those clones tend to reappear. Since gg7.0 there is an additional (first one) line in contact list. It contains 'GG70ExportString'. Parsing such a list with old algoritm will return a contact with number 0. I deleted contact list from gg server (in original client), then I cleared kopete's contact list and after connection contact 'GG70ExportString' appeared in kopete (with number 0). With every next connection one more GG70ExportString contact is appearing. If there are some contacts in kopete's contact list, these are somehow mixed with that with 0 number. With every connection to gg, one more (or more) contact with 0 number is appearing but it's name is one of these from the list (can be GG70ExportString). I get about 30 now "0"contacts every start and no deleting of contactlist on server helps. I tried to delete contactlist with pidgin and it didn't help. For now maybe disabling autosychronisation of contacts (#185230) would be a workaround... 0 isnt a contact realy, is number of that is used by gadu gadu to send comercial stuff, this thing should be blocked by kopete. Created attachment 38006 [details]
Path for gaducontactlist.cpp
It solves:
-Crashing when deleting
-Importing '0' contact
-Export now works and can be imported in native program
Also polish characters wasn't working, so I made another patch: (I'm sorry for publishing it in this bug...) --- kdenetwork-4.3.1/kopete/protocols/gadu/gadusession.cpp 2008-12-10 17:14:05.000000000 +0100 +++ kopete-4.2.4/kopete/protocols/gadu/gadusession.cpp 2009-11-01 13:18:00.000000000 +0100 @@ -550,9 +550,9 @@ QString ul; switch( event->event.userlist.type ) { case GG_USERLIST_GET_REPLY: if ( event->event.userlist.reply ) { - ul = event->event.userlist.reply; + ul = textcodec->toUnicode(event->event.userlist.reply); kDebug( 14100 ) << "Got Contacts list OK "; } else { kDebug( 14100 ) << "Got Contacts list FAILED/EMPTY "; Sorry, if the patch is in wrong format, I have generated it for the first time. Please open a ticket on reviewboard.kde.org and add the patch thanks Is this problem still happening? Can I close this bug? The patch in comment #6 was applied in kopete some time ago. I will apply the patch in comment #7. SVN commit 1225171 by lvsouza: Apply fix for lack of unicode translation in Gadu plugin. Thanks Maciej `Matrach` Matraszek for the patch. CCBUG: 147434 FIXED-IN: 4.6.2 M +1 -1 gadusession.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1225171 SVN commit 1225172 by lvsouza: Backporting r1225171: Apply fix for lack of unicode translation in Gadu plugin. Thanks Maciej `Matrach` Matraszek for the patch. CCBUG: 147434 FIXED-IN: 4.6.2 M +1 -1 gadusession.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1225172 |