| Summary: | window.onscroll event handler is not called | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Michael Schuerig <michael> |
| Component: | khtml ecma | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | luke-jr+kdebugs, maksim |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Example for non-functional window.onscroll
Example for working window.addEventListener('scroll', ...) patch. Not well-tested |
||
|
Description
Michael Schuerig
2007-06-26 17:53:46 UTC
Created attachment 20974 [details]
Example for non-functional window.onscroll
Created attachment 20975 [details]
Example for working window.addEventListener('scroll', ...)
Yeah, we don't bind onscroll, just list it as an IE extension we don't handle. Should be easy enough to do. Created attachment 22235 [details]
patch. Not well-tested
This makes us bind it... I wonder why it wasn't added before, though.
We also seem to emit it on scrollwheel changes even if there is no scrollbar.
patch looks all fine but wouldn't that prevent an addEventListener path to be triggered? (and thus possibly end up having us identified as IE on some sites?)
Which browsers support it?
> We also seem to emit it on scrollwheel changes even if there is no scrollbar.
it should check, in KHTMLView::scrollContentsBy(x,y), that the offset is non-zero before emitting the scroll event.
SVN commit 755002 by ggarand: Don't fire a scroll event if the view has been scrolled by a (0,0) delta. This happen when a view deprived of scrolling controls receives e.g. a wheel event. CCBUG: 147256 M +1 -1 khtmlview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=755002 This bug is still open in 4.0.1, and combined with bug 157375 break my webapp. Handled in newer versions... |