Bug 147248

Summary: Image info doesn't follow image in the editor
Product: [Applications] digikam Reporter: Paweł Marciniak <pave>
Component: ImageEditor-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.9.3
Attachments: changes one line that have been left unchanged afer a copy-paste

Description Paweł Marciniak 2007-06-26 16:03:30 UTC 
Version:            (using KDE KDE 3.5.7)
Installed from:    Unlisted Binary Package
OS:                Linux

When I do File->Last (or ctrl-PgDn) in the image editor mode, the image info sidebar gets desynchronized with the actual image. That way it's very easy to comment, say, 200 images only to realize at the end that the comments are saved into wrong files, which doesn't necessarily give you a nice feeling.

I took a look at the source and it turned out to be a stupid copy-paste bug. Proposed patch attached.
Comment 1 Paweł Marciniak 2007-06-26 16:04:36 UTC 
Created attachment 20972 [details]
changes one line that have been left unchanged afer a copy-paste
Comment 2 Paweł Marciniak 2007-06-26 16:06:13 UTC 
This bug may have something to do with an old bug #133516 that was closed with WORKSFORME.
Comment 3 caulier.gilles 2007-06-26 16:22:00 UTC 
Marcel,

It just a copy and paste failure (:=)))...

Patch is fine for you ?

Gilles
Comment 4 caulier.gilles 2007-06-26 16:24:04 UTC 
Achim, Angelo,

If patch is fine for Marcel... please unforget to backport it into 0.9.2 package. 

Just follow this thread before to patch DEB and RPM

Thanks in advance...

Gilles
Comment 5 Marcel Wiesweg 2007-06-26 18:35:43 UTC 
SVN commit 680586 by mwiesweg:

Applying the patch from Pawel Marciniak to fix copy-and-paste bug.
Thank you very much for your patch.

BUG: 147248


 M  +1 -1      imagewindow.cpp  


--- branches/extragear/kde3/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp #680585:680586
@@ -533,7 +533,7 @@
         return;
 
     d->urlCurrent = d->urlList.last();
-    d->imageInfoCurrent = d->imageInfoList.first();
+    d->imageInfoCurrent = d->imageInfoList.last();
     slotLoadCurrent();
 }