Summary: | moodbar layered on top of volume control | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | richlv |
Component: | Notifications | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Slackware | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | screenshot |
Description
richlv
2007-06-25 14:26:13 UTC
Created attachment 20951 [details]
screenshot
15:01 < CIA-5> markey * r680113 /branches/stable/extragear/multimedia/amarok/src/osd.cpp: 15:01 < CIA-5> Revert part of the patch for BUG 147059 that apparently caused the moodbar to malfunction in the OSD. Rich, does that fix it? yep, now moodbar isn't shown constantly. it still might creep out now and then, but i will probably have to come up with a way to reproduce that one reliably anyway. Thanks, should we consider this report fixed, or leave it open? i'd say, fixed. if i or anybody else comes up with a way to reproduce the sporadic behaviour, it can be reopened. i've seen this behaviour since moodbar was introduced, but have never gotten more information regarding reproducability. *** Bug has been marked as fixed ***. SVN commit 680951 by markey: Patch by Tuomas that keeps the moodbar shown when cycling through ratings, _without breaking anything(?)_ this time. CCBUG: 146918 CCBUG: 147199 M +1 -0 app.cpp M +1 -0 osd.cpp --- branches/stable/extragear/multimedia/amarok/src/app.cpp #680950:680951 @@ -1254,6 +1254,7 @@ CollectionDB::instance()->setSongRating( path, n, true ); const int rating = CollectionDB::instance()->getSongRating( path ); EngineController::instance()->updateBundleRating( rating ); + Amarok::OSD::instance()->OSDWidget::setMoodbar( EngineController::instance()->bundle() ); Amarok::OSD::instance()->OSDWidget::ratingChanged( rating ); if( !Amarok::OSD::instance()->isShown() && !PlaylistWindow::self()->isReallyShown() ) Amarok::OSD::instance()->forceToggleOSD(); --- branches/stable/extragear/multimedia/amarok/src/osd.cpp #680950:680951 @@ -94,6 +94,7 @@ //m_text = '\n' + i18n( "Rating changed" ); setRating( rating ); //Checks isEnabled() before doing anything + OSDWidget::setMoodbar( EngineController::instance()->bundle() ); if( isShown() ) show(); } |