Summary: | 1.4.0: crash when changing data vector of a PSD | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | D. V. Wiebe <dvw> |
Component: | general | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
backtrace
fix |
Description
D. V. Wiebe
2007-04-16 22:50:33 UTC
Created attachment 20291 [details]
backtrace
This bug is serious enough to delay 1.4.0 until fixed (if possible). cbn On Monday 16 April 2007 4:50:34 pm D.V.Wiebe wrote: [bugs.kde.org quoted mail] It's probably related to the locking changes. I doubt setVector() should be (un)locking the input vector. I wouldn't be surprised if this also occurs with Spectrograms and Histograms. Can you try to track it down before we release? > ------- Additional Comments From eli staikos net 2007-04-16 23:34 ------- > It's probably related to the locking changes. I doubt setVector() should be > (un)locking the input vector. > > I wouldn't be surprised if this also occurs with Spectrograms and > Histograms. Created attachment 20292 [details]
fix
Any idea why the locks were there in the first place? cbn We used to lock all the inputs and outputs of data objects whenever we locked the object itself. This caused deadlocks and performance issues, so now we only lock the inputs/outputs in update(). Because setVector() was called when the object was locked, the inputs had to be put in a locked state. I'm not sure if it is related, but changing the matrix source of an image silently fails. In other words, create 2 matrix objects (say both from tests/asciimatrix.txt) and then create an image from matrix #1. Now go into the image dialog and select matrix #2 from the list. Click OK. Open the image dialog again and... matrix #1 is still selected! I guess this probably belongs in a separate bug report... -Ted On Monday 16 April 2007 13:50, D.V.Wiebe wrote: [bugs.kde.org quoted mail] I think this patch is correct. It should go into trunk, 1.5 branch, and I will retag 1.4 -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/ Was checked in to 1.5 branch by Eli |