Bug 143319

Summary:	Operation Properties "Type" combo box too small
Product:	[Applications] umbrello	Reporter:	Wickersheimer Jeremy <jwickers>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	see bug report

Description Wickersheimer Jeremy 2007-03-22 04:24:22 UTC

Version:           1.5.6 > svn 644513 (using KDE KDE 3.5.6)
Installed from:    Gentoo Packages
OS:                Linux

In the "Operation Properties" dialog, the "Type" combo box (for the return type) is very small compared to the operation param type (for example).
It also doesn't resize with the dialog.

This is very problematic when returning classes that are in packages/subpackages ... as all that can be displayed is the name of the first package.

I join a patch for umbrello/dialogs/umloperationdialog.cpp for svn (r644513) but also applies to 1.5.6 (and probably 1.5.61).
The patch just set the column stretch factor for col 1 and 3 (name and type respectively), and set the minimum size for each of these field to 200 (could be reduced if you think it may cause problem on small screens).

So now the default size is big enough and the fields both resize with the dialog.

Comment 1 Wickersheimer Jeremy 2007-03-22 04:25:21 UTC

Created attachment 20064 [details]
see bug report

Comment 2 Oliver Kellogg 2007-03-22 06:39:48 UTC

SVN commit 645266 by okellogg:

Apply attachment 20064 [details] from Wickersheimer Jeremy:
> The patch just set the column stretch factor for col 1 and 3 (name and type
> respectively) [...]

Thank you for contributing.
BUG:143319


 M  +1 -0      ChangeLog  
 M  +1 -0      THANKS  
 M  +4 -0      umbrello/dialogs/umloperationdialog.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/ChangeLog #645265:645266
@@ -27,6 +27,7 @@
 * Ada code generator always generates methods abstract even if abstract box
   not checked (142093)
 * Missing "with" on Ada code generation for aggregation (142392)
+* Operation Properties "Type" combo box too small (143319)
 
 Version 1.5.61
 
--- branches/KDE/3.5/kdesdk/umbrello/THANKS #645265:645266
@@ -81,6 +81,7 @@
 Jean Vittor <jean.vittor @wanadoo.fr>
 Egbert Voigt <Egbert.Voigt @alcatel.de>
 Stefan Walter <sw @gegenunendlich.de>
+Jeremy Wickersheimer <jwickers @gmail.com>
 Yurgen Wolfgang <raptorsforever @softhome.net>
 Maciej J. Woloszyk <mat @esi.com.pl>
 Tobias Wulff <Tobias-Wulff @codeeye.de>
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/dialogs/umloperationdialog.cpp #645265:645266
@@ -64,6 +64,10 @@
 
     m_pGenGB = new QGroupBox(i18n("General Properties"), plainPage() );
     QGridLayout * genLayout = new QGridLayout(m_pGenGB, 3, 4 );
+    genLayout -> setColStretch(1, 1);
+    genLayout -> setColStretch(3, 1);
+    genLayout -> addColSpacing(1, 200);
+    genLayout -> addColSpacing(3, 200);
     genLayout -> setMargin(margin);
     genLayout -> setSpacing(10);