Summary: | Build fails when MetaEngine is in $PREFIX, but not in $KDEDIR or standard include directories | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Chris Spiegel <cspiegel> |
Component: | Portability-Cmake | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.9.1 |
Description
Chris Spiegel
2007-02-23 02:02:25 UTC
Hi, Are you compiled and linked sucessfully kipi-plugins in this case ? Gilles Caulier SVN commit 636458 by cgilles: missing libkexiv2 includes CCBUGS: 142088 M +1 -0 Makefile.am --- trunk/extragear/graphics/digikam/digikam/Makefile.am #636457:636458 @@ -22,6 +22,7 @@ -I$(top_srcdir)/digikam/utilities/setup \ -I$(top_srcdir)/digikam/utilities/slideshow \ -I$(top_srcdir)/digikam/utilities/batch \ + $(LIBKEXIV2_CFLAGS) $(LIBKIPI_CFLAGS) $(GPHOTO_CFLAGS) $(all_includes) Please let's me hear if digikam from svn trunk compile fine for you now... Gilles Caulier I just checked out the latest from svn and the problem still persists. digikam/digikam/Makefile does add LIBKEXIV2_CFLAGS to INCLUDES, but that particular INCLUDES isn't used when the build fails. There are many locations that make use of libkexiv2, but the first that fails is digikam/libs/dimg/loaders. The Makefile in this directory sets its own INCLUDES variable which does not pull in LIBKEXIV2_CFLAGS. Give us a compilation trace... Gilles Caulier SVN commit 636830 by cgilles: digikam from trunk: fix all Makefile.am witch require libkexiv2 includes CCBUGS: 142088 M +1 -0 kioslave/Makefile.am M +1 -0 libs/dimg/loaders/Makefile.am M +1 -0 libs/imageproperties/Makefile.am M +1 -0 libs/jpegutils/Makefile.am M +1 -0 libs/threadimageio/Makefile.am M +1 -0 libs/widgets/metadata/Makefile.am M +1 -0 showfoto/Makefile.am M +1 -0 utilities/cameragui/Makefile.am M +1 -0 utilities/imageeditor/canvas/Makefile.am M +1 -0 utilities/imageeditor/editor/Makefile.am --- trunk/extragear/graphics/digikam/kioslave/Makefile.am #636829:636830 @@ -3,6 +3,7 @@ INCLUDES = -I$(top_srcdir)/digikam/libs/jpegutils \ -I$(top_srcdir)/digikam/libs/dimg \ -I$(top_srcdir)/digikam/libs/dmetadata \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/libs/dcraw \ -I$(top_srcdir)/digikam/digikam \ $(all_includes) --- trunk/extragear/graphics/digikam/libs/dimg/loaders/Makefile.am #636829:636830 @@ -14,4 +14,5 @@ INCLUDES = $(all_includes) -I$(top_srcdir)/digikam/libs/dimg \ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dcraw \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/digikam --- trunk/extragear/graphics/digikam/libs/imageproperties/Makefile.am #636829:636830 @@ -45,6 +45,7 @@ -I$(top_srcdir)/digikam/libs/threadimageio \ -I$(top_srcdir)/digikam/utilities/cameragui \ -I$(top_srcdir)/digikam/utilities/batch \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/digikam \ $(all_includes) --- trunk/extragear/graphics/digikam/libs/jpegutils/Makefile.am #636829:636830 @@ -8,6 +8,7 @@ INCLUDES = $(all_includes) \ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dimg \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/digikam noinst_LTLIBRARIES = libjpegutils.la --- trunk/extragear/graphics/digikam/libs/threadimageio/Makefile.am #636829:636830 @@ -18,6 +18,7 @@ -I$(top_srcdir)/digikam/libs/dimg/loaders \ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dcraw \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/libs/jpegutils \ -I$(top_srcdir)/digikam/digikam \ $(all_includes) --- trunk/extragear/graphics/digikam/libs/widgets/metadata/Makefile.am #636829:636830 @@ -11,5 +11,6 @@ INCLUDES = -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dimg \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/digikam \ $(all_includes) --- trunk/extragear/graphics/digikam/showfoto/Makefile.am #636829:636830 @@ -15,6 +15,7 @@ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/threadimageio \ -I$(top_srcdir)/digikam/digikam \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/utilities/slideshow \ -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \ -I$(top_srcdir)/digikam/utilities/imageeditor/editor \ --- trunk/extragear/graphics/digikam/utilities/cameragui/Makefile.am #636829:636830 @@ -23,6 +23,7 @@ -I$(top_srcdir)/digikam/libs/jpegutils \ -I$(top_srcdir)/digikam/libs/themeengine \ -I$(top_srcdir)/digikam/libs/imageproperties \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/libs/widgets/common \ -I$(top_srcdir)/digikam/libs/dimg \ -I$(top_srcdir)/digikam/libs/dmetadata \ --- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/Makefile.am #636829:636830 @@ -16,6 +16,7 @@ -I$(top_srcdir)/digikam/libs/dimg/filters \ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dialogs \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/libs/histogram \ -I$(top_srcdir)/digikam/libs/threadimageio \ -I$(top_srcdir)/digikam/utilities/splashscreen \ --- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/Makefile.am #636829:636830 @@ -24,6 +24,7 @@ -I$(top_srcdir)/digikam/libs/dimg/filters \ -I$(top_srcdir)/digikam/libs/imageproperties \ -I$(top_srcdir)/digikam/libs/threadimageio \ + $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/utilities/setup \ -I$(top_srcdir)/digikam/utilities/slideshow \ -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \ Ok, now all is fixed ? Gilles Almost. If the same addition is made to utilities/batch/Makefile.am then the build completes. Thanks! Marcel, Gerhard or Achim can you fix it in svn and close this file<; <unforget to report this B.K.O titile in NEWS file. Thanks in advance Gilles 25 Feb 2007 01:09:35 -0000, kde@happyjack.org <kde@happyjack.org>: [bugs.kde.org quoted mail] <div>Marcel, Gerhard or Achim can you fix it in svn and close this file<; <unforget to report this B.K.O titile in NEWS file. Thanks in advance</div> <div> </div> <div>Gilles <br><br> </div> <div><span class="gmail_quote">25 Feb 2007 01:09:35 -0000, <a href="mailto:kde@happyjack.org">kde@happyjack.org</a> <<a href="mailto:kde@happyjack.org">kde@happyjack.org</a>>:</span> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">------- You are receiving this mail because: -------<br>You are the assignee for the bug, or are watching the assignee. <br><br><a href="http://bugs.kde.org/show_bug.cgi?id=142088">http://bugs.kde.org/show_bug.cgi?id=142088</a><br><br><br><br><br>------- Additional Comments From kde happyjack org 2007-02-25 02:09 -------<br>Almost. If the same addition is made to utilities/batch/Makefile.am then the build completes. <br><br>Thanks!<br>_______________________________________________<br>Digikam-devel mailing list<br><a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/digikam-devel"> https://mail.kde.org/mailman/listinfo/digikam-devel</a><br></blockquote></div><br> SVN commit 637720 by mwiesweg: Fix the last missing Makefile.am to contain exiv2 includes BUG: 142088 M +1 -0 Makefile.am --- trunk/extragear/graphics/digikam/utilities/batch/Makefile.am #637719:637720 @@ -6,6 +6,7 @@ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/thumbbar \ -I$(top_srcdir)/digikam/libs/widgets/common \ + $(LIBKEXIV2_CFLAGS) \ $(all_includes) noinst_LTLIBRARIES = libbatch.la Thanks Marcel, to "kde happyjack org" : are you tried to compile DigikamImagePlugins at the same time than digiKam when you checkout all extragear/graphics source code. Normally DigikamImagePlugins don't depnd on libkexiv2 directly, but i would to be sure before 0.9.1 final release... Gilles 27 Feb 2007 15:14:45 -0000, Marcel Wiesweg <marcel.wiesweg@gmx.de>: [bugs.kde.org quoted mail] <div>Thanks Marcel,</div> <div> </div> <div>to "kde happyjack org" : are you tried to compile DigikamImagePlugins at the same time than digiKam when you checkout all extragear/graphics source code. Normally DigikamImagePlugins don't depnd on libkexiv2 directly, but i would to be sure before 0.9.1 final release... </div> <div> </div> <div>Gilles <br><br> </div> <div><span class="gmail_quote">27 Feb 2007 15:14:45 -0000, Marcel Wiesweg <<a href="mailto:marcel.wiesweg@gmx.de">marcel.wiesweg@gmx.de</a>>:</span> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">------- You are receiving this mail because: -------<br>You are the assignee for the bug, or are watching the assignee. <br><br><a href="http://bugs.kde.org/show_bug.cgi?id=142088">http://bugs.kde.org/show_bug.cgi?id=142088</a><br>marcel.wiesweg gmx de changed:<br><br> What |Removed |Added<br>---------------------------------------------------------------------------- <br> Status|UNCONFIRMED |RESOLVED<br> Resolution| |FIXED<br><br><br><br>------- Additional Comments From marcel.wiesweg gmx de 2007-02-27 16:14 -------<br>SVN commit 637720 by mwiesweg: <br><br>Fix the last missing <a href="http://Makefile.am">Makefile.am</a> to contain exiv2 includes<br><br>BUG: 142088<br><br><br>M +1 -0 <a href="http://Makefile.am">Makefile.am</a><br><br><br>--- trunk/extragear/graphics/digikam/utilities/batch/Makefile.am #637719:637720 <br>@ -6,6 +6,7 @<br> -I$(top_srcdir)/digikam/libs/dmetadata \<br> -I$(top_srcdir)/digikam/libs/thumbbar \<br> -I$(top_srcdir)/digikam/libs/widgets/common \<br>+ $(LIBKEXIV2_CFLAGS) \<br> $(all_includes)<br><br>noinst_LTLIBRARIES = <a href="http://libbatch.la">libbatch.la</a><br>_______________________________________________<br>Digikam-devel mailing list<br><a href="mailto:Digikam-devel@kde.org"> Digikam-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/digikam-devel">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br></blockquote></div><br> I just checked out the latest svn of both digikam and digikamimageplugins and they're both building with no problems. |