Summary: | Remove from diagram or Delete item are not understandable | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Ferenc Veres <lion> |
Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bcooksley, ralf.habacker |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/umbrello/5439692a2ab11fcb472f0b9b116b94f493579a2c | Version Fixed In: | 2.25.80 (KDE Applications 18.07.80) |
Description
Ferenc Veres
2007-02-17 00:06:33 UTC
see also bug 124587 Git commit 37f9014cb0afb897c261d7f70cdf10ad7d467497 by Ralf Habacker. Committed on 28/03/2018 at 00:46. Pushed by habacker into branch 'master'. Rename 'Delete' in widget context menu for cloneable widgets to 'Remove' When deleting cloneable widgets (widgets that have a related uml object), are in fact removed from the scene, so the associated context menu entry should match that. M +2 -0 umbrello/icon_utils.cpp M +1 -0 umbrello/icon_utils.h M +7 -2 umbrello/listpopupmenu.cpp M +1 -0 umbrello/listpopupmenu.h M +1 -1 umbrello/umlwidgets/widgetbase.cpp https://commits.kde.org/umbrello/37f9014cb0afb897c261d7f70cdf10ad7d467497 Git commit 12c5ed24e79080f922d9cae1eae02cc41dde118e by Ralf Habacker. Committed on 05/04/2018 at 20:35. Pushed by habacker into branch 'master'. In UMLScene::deleteSelection() fix number of selection count UMLScene::selectedWidgets() returns widgets based on class UMLWidget, which includes message widgets, but not association widgets. M +3 -4 umbrello/umlscene.cpp https://commits.kde.org/umbrello/12c5ed24e79080f922d9cae1eae02cc41dde118e Git commit 5439692a2ab11fcb472f0b9b116b94f493579a2c by Ralf Habacker. Committed on 10/04/2018 at 21:15. Pushed by habacker into branch 'master'. Ask user for permission to delete an association from a diagram using the context menu This commit includes a fix for deleting associations (message widgets) in sequence diagrams without confirmation. FIXED-IN:2.25.80 (KDE Applications 18.07.80) M +1 -0 umbrello/CMakeLists.txt M +21 -0 umbrello/dialogs/dialog_utils.cpp M +1 -0 umbrello/dialogs/dialog_utils.h A +142 -0 umbrello/dialogs/dontaskagain.cpp [License: GPL (v2+)] A +116 -0 umbrello/dialogs/dontaskagain.h [License: GPL (v2+)] M +5 -1 umbrello/dialogs/settingsdialog.cpp M +2 -0 umbrello/dialogs/settingsdialog.h M +15 -11 umbrello/umlscene.cpp M +2 -0 umbrello/umlwidgets/associationwidget.cpp M +5 -2 umbrello/umlwidgets/messagewidget.cpp M +7 -0 umbrello/umlwidgets/widgetbase.cpp https://commits.kde.org/umbrello/5439692a2ab11fcb472f0b9b116b94f493579a2c Git commit b51894d1a3178205b8aacfd8211514909ccd8695 by Ralf Habacker. Committed on 10/04/2018 at 21:15. Pushed by habacker into branch 'master'. Add "don't ask again" checkbox to Dialog_Utils::askDeleteDiagram() M +21 -0 umbrello/dialogs/dialog_utils.cpp M +1 -0 umbrello/dialogs/dialog_utils.h M +1 -6 umbrello/umldoc.cpp M +1 -4 umbrello/umlscene.cpp https://commits.kde.org/umbrello/b51894d1a3178205b8aacfd8211514909ccd8695 https://bugs.kde.org/show_activity.cgi?id=141809 looks odd... Could you please check the status? (In reply to Christoph Feck from comment #6) > https://bugs.kde.org/show_activity.cgi?id=141809 looks odd... > > Could you please check the status? Thanks for this pointer, see https://phabricator.kde.org/T8498 I've taken a look and based on what has taken place in the history it looks like the two commits have raced each other when being processed by the hooks - hence why the history is a bit weird. |