Bug 141672

Summary:	right-clicking on sound control changes volume
Product:	[Applications] amarok	Reporter:	Silver Salonen <silver.salonen>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adalvit
Priority:	NOR
Version:	1.4.5
Target Milestone:	---
Platform:	FreeBSD Ports
OS:	FreeBSD
Latest Commit:		Version Fixed In:

Description Silver Salonen 2007-02-14 09:20:24 UTC

Version:            (using KDE KDE 3.5.5)
Installed from:    FreeBSD Ports
OS:                FreeBSD

In previous versions volume was changed when clicking with left button. Now, in 1.4.5, the right button both changes volume and shows the volume menu.

Comment 1 Mark Kretschmann 2007-02-14 10:14:01 UTC

SVN commit 633527 by markey:

Fix regression: right-clicking on sound control would change volume

BUG: 141672


 M  +9 -0      sliderwidget.cpp  
 M  +1 -0      sliderwidget.h  


--- branches/stable/extragear/multimedia/amarok/src/sliderwidget.cpp #633526:633527
@@ -414,6 +414,15 @@
 }
 
 void
+Amarok::VolumeSlider::mousePressEvent( QMouseEvent *e )
+{
+    if( e->button() != RightButton ) {
+        Amarok::Slider::mousePressEvent( e );
+        slideEvent( e );
+    }
+}
+                
+void
 Amarok::VolumeSlider::contextMenuEvent( QContextMenuEvent *e )
 {
     KPopupMenu menu;
--- branches/stable/extragear/multimedia/amarok/src/sliderwidget.h #633526:633527
@@ -129,6 +129,7 @@
             virtual void leaveEvent( QEvent* );
             virtual void paletteChange( const QPalette& );
             virtual void slideEvent( QMouseEvent* );
+            virtual void mousePressEvent( QMouseEvent* );
             virtual void contextMenuEvent( QContextMenuEvent* );
             virtual void wheelEvent( QWheelEvent *e );

Comment 2 Mark Kretschmann 2007-02-14 10:29:27 UTC

SVN commit 633534 by markey:

Forward-port bugfix from stable branch: Right-click on volume slider would change volume

CCBUG: 141672


 M  +9 -0      sliderwidget.cpp  
 M  +1 -0      sliderwidget.h  


--- trunk/extragear/multimedia/amarok/src/sliderwidget.cpp #633533:633534
@@ -441,6 +441,15 @@
 }
 
 void
+Amarok::VolumeSlider::mousePressEvent( QMouseEvent *e )
+{
+    if( e->button() != Qt::RightButton ) {
+        Amarok::Slider::mousePressEvent( e );
+        slideEvent( e );
+    }
+}
+                
+void
 Amarok::VolumeSlider::contextMenuEvent( QContextMenuEvent *e )
 {
     Q3PopupMenu menu;
--- trunk/extragear/multimedia/amarok/src/sliderwidget.h #633533:633534
@@ -136,6 +136,7 @@
             virtual void leaveEvent( QEvent* );
             virtual void paletteChange( const QPalette& );
             virtual void slideEvent( QMouseEvent* );
+            virtual void mousePressEvent( QMouseEvent* );
             virtual void contextMenuEvent( QContextMenuEvent* );
             virtual void wheelEvent( QWheelEvent *e );

Comment 3 Kevin Funk 2007-02-19 22:58:14 UTC

*** Bug 141948 has been marked as a duplicate of this bug. ***