Bug 137972

Summary:	[test case] textarea custom border dissapears when overflow is set to something different then visible
Product:	[Applications] konqueror	Reporter:	Chris van de Wouw <chrisje>
Component:	khtml forms	Assignee:	Allan Sandfeld <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	finex
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description Chris van de Wouw 2006-11-27 15:10:43 UTC

Version:            (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

When applying a custom border to form fields, this normally works. But when a textarea also has attribute 'overflow' set to something different as 'visible', the custom border disappears.


testcase:
<form action="#" method="POST">
  <p><input type="text" style="border: 1px solid #000;" value="bordered input field"></p>
  <p><textarea style="border: 1px solid #000;">Bordered textarea</textarea></p>
  <p><textarea style="border: 1px solid #000; overflow: scroll;">Hey, where's my border?</textarea></p>
</form>

Comment 1 Allan Sandfeld 2006-11-28 11:31:34 UTC

I think I have a patch for this somewhere.

Comment 2 Allan Sandfeld 2006-11-29 14:30:03 UTC

This simple patch fixes it.

Index: rendering/render_form.h
===================================================================
--- rendering/render_form.h     (revision 605929)
+++ rendering/render_form.h     (working copy)
@@ -85,6 +85,7 @@
     virtual int paddingRight() const { return 0; }

     virtual void updateFromElement();
+    virtual bool requiresLayer() { return false; }

     virtual void layout();
     virtual short baselinePosition( bool ) const;

Comment 3 FiNeX 2008-04-21 00:11:30 UTC

bug fixed on konqueror 4 (but not in 3.5.8)

Comment 4 Maksim Orlovich 2009-02-15 21:33:08 UTC

That means it's fixed :)