Bug 137233

Summary: Proper input constraints in New Album dialog
Product: [Applications] digikam Reporter: Martin Ringehahn <martin>
Component: Albums-MainViewAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.8.2   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0

Description Martin Ringehahn 2006-11-12 14:14:27 UTC 
Version:           0.8.2 (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages

When i create a new album, i have to adhere to input constraints, eg for the title which must not contain any forward slashes. If i enter such symbols and try to confirm the dialog via 'ok' there comes an error message (for example "Der Albumname darf keinen Schraegstrich enthalten", german for the forward slash problem).

Problem is: after i confirmed the error, my original Dialog with all other input done by me is lost - which makes this a  usability _bug_ in my eyes.

There should either be some constraints on those input fields - that i cannot enter eg forward slashes in the first time - or this error has to bring me back my original dialog with all my input i had already done.
Comment 1 John Aylward 2006-11-25 23:07:58 UTC 
I'm having this same problem with 0.9.0-rc1 on Linux Gentoo installed from Gentoo packages. I'd like to see the tagging consistant.

Suggestions:
Have the right tag panel auto-update when images are select with the images selections. It should keep a tally of how many selected images have each tag (t=0 - no check mark; t<s - grey check mark; s=n - regular check mark; where s=number selected, and t=tally for each tag)

when checking the tags:
* if the tag is already selected for all selected images, or if the tag is not selected for any of the selected images, it should just toggle the tag on all the images.

* if some of the selected images are selected, it should toggle to all images having the tag, then no images having the tag, then back to the original images having the tag.
Comment 2 Andi Clemens 2008-12-03 12:24:15 UTC 
> There should either be some constraints on those input fields - that i cannot enter eg forward slashes in the first time - or this error has to bring me back my original dialog with all my input i had already done.

Rather old bug, but still present in 0.10.
I also would suggest to just filter out the forward slashes or add some kind of validation so that the dialog can still be used and is not closed before this error message appears.

Andi
Comment 3 caulier.gilles 2008-12-03 12:29:40 UTC 
Why not to use QRegExp for that :

http://doc.trolltech.com/4.4/qregexp.html

like i use here :

http://lxr.kde.org/source/extragear/graphics/kipi-plugins/metadataedit/exifcaption.cpp#102

Gilles
Comment 4 Andi Clemens 2008-12-03 12:33:29 UTC 
Good idea, I will take a look at that...

Andi
Comment 5 Andi Clemens 2008-12-03 13:40:34 UTC 
SVN commit 891982 by aclemens:

use a validator to restrict new album name.

BUG:137233

 M  +2 -1      NEWS  
 M  +6 -0      digikam/albumpropsedit.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=891982
Comment 6 Andi Clemens 2008-12-03 13:49:15 UTC 
SVN commit 891983 by aclemens:

backport commit #891982 from trunk

CCBUG:137233


 M  +23 -17    albumpropsedit.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=891983