Bug 137198

Summary: PATCH make akode-engine still compile
Product: [Applications] amarok Reporter: Cyrille Dunant <cyrille.dunant>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Cyrille Dunant 2006-11-11 15:58:55 UTC
Version:           unknown (using KDE 3.5.5, compiled sources)
Compiler:          gcc version 3.3.4 (pre 3.3.5 20040809)
OS:                Linux (x86_64) release 2.6.14.1

I realise that akode is not supported anymore, but it happens to be the only engine which plays all my files without bug or crash.

Would you mind integrating the following patch which simply adds a required member to the engine ?



Index: akode-engine.cpp
===================================================================
--- akode-engine.cpp    (revision 604085)
+++ akode-engine.cpp    (working copy)
@@ -87,6 +87,11 @@
     return true;
 }

+void AkodeEngine::unpause()
+{
+       m_player->play();
+}
+
 bool
 


AkodeEngine::canDecode( const KURL &url ) const
 {
Index: akode-engine.h
===================================================================
--- akode-engine.h      (revision 604085)
+++ akode-engine.h      (working copy)
@@ -22,6 +22,7 @@
     virtual bool play( uint );
     virtual void stop();
     virtual void pause();
+    virtual void unpause() ;
     virtual void setVolumeSW( uint );
     virtual void seek( uint );
Comment 1 Alexandre Oliveira 2006-11-11 19:29:08 UTC
Sorry, but we actually can't do that. Akode engine was removed from the repository.
Comment 2 Seb Ruiz 2006-11-12 05:58:35 UTC
Ah, it's actually still there.
Comment 3 Seb Ruiz 2006-11-12 06:00:35 UTC
SVN commit 604227 by seb:

Make akode-engine compile, despite Untouchable's delusions :)
BUG: 137198


 M  +6 -0      akode-engine.cpp  
 M  +1 -0      akode-engine.h  


--- trunk/extragear/multimedia/amarok/src/engine/akode/akode-engine.cpp #604226:604227
@@ -87,6 +87,12 @@
     return true;
 }
 
+void
+AkodeEngine::unpause()
+{
+    m_player->play();
+}
+
 bool
 AkodeEngine::canDecode( const KURL &url ) const
 {
--- trunk/extragear/multimedia/amarok/src/engine/akode/akode-engine.h #604226:604227
@@ -22,6 +22,7 @@
     virtual bool play( uint );
     virtual void stop();
     virtual void pause();
+    virtual void unpause();
     virtual void setVolumeSW( uint );
     virtual void seek( uint );
 
Comment 4 Cyrille Dunant 2006-11-12 10:13:01 UTC
On Sunday 12 November 2006 06:00, Seb Ruiz wrote:
[bugs.kde.org quoted mail]

Thank you very much !