Bug 136934

Summary: "Change icon" for an action that is not currently on the toolbar
Product: [Frameworks and Libraries] kdelibs Reporter: Ryan Saunders <saunders>
Component: kedittoolbarAssignee: David Faure <faure>
Status: REPORTED ---    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Mandriva RPMs   
OS: Linux   
Latest Commit: Version Fixed In:

Description Ryan Saunders 2006-11-06 09:42:03 UTC 
Version:            (using KDE KDE 3.5.4)
Installed from:    Mandriva RPMs

In the "configure toolbar" dialog, the "change icon" button does not behave as expected when the selected action is in the "available actions" list.

Repro steps:
  1. Select an item in the available actions list
  2. Click "Change Icon". Choose something and click OK.

Expected result: the selected action in the available actions list has the new icon
Actual result: the selected action is unchanged, and the bottom-most action in the "current actions" list has had the new icon applied to it

Ideally, I should be able to customize the icons for actions that aren't currently on my toolbar. If this is not feasible for some reason, then the "Change Icon" button should be disabled when the selection is in the "available actions" list.
Comment 1 David Faure 2007-12-21 19:14:02 UTC 
Well this is because "Change Icon" applies to the selected action in the "Current actions" list, as shown by the fact that it's directly under this list.

Changing the icon of an icon that isn't in a toolbar is problematic, since we wouldn't know in which xml file to save the icon change; it would have to be "the file(s) where the menu that uses this action is defined", which is quite orthogonal to the toolbar editor's purpose (editing toolbars, not menus).

I think this is out of scope for the toolbar editor.


> the "Change Icon" button should be disabled when the selection is in the "available actions" list. 
But you have one selection in each list, it's not "one or the other list is selected"... So as long as you have a selected item in the "Current actions" list, the Change Icon button is enabled. I think this works as expected...
Comment 2 David Faure 2008-01-03 15:20:56 UTC 
Retitling; turning into wish.