| Summary: | KWallet loses new passwords when closed since XML file import | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kdelibs | Reporter: | Sebastien Raveau <sebastien.raveau> |
| Component: | kwallet | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | esigra, giovanni.bobbio, jani-matti.hatinen, lemma, martin.zboril |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | sync kwallet changes immediately | ||
|
Description
Sebastien Raveau
2006-10-28 14:10:47 UTC
I can't add passwords to my kwallet, either. I didn't go through a complicated route as the original reporter, kwallet just stopped saving passwords in the wallet file I've been using for some time. Creating a new, empty, wallet didn't solve the issue. Confirmed here too. When new entries are added to my default wallet, they all are lost if I logout/login... Should be considered critical since most apps use kwallet to store identification infos. There is a bugreport on this at launchpad as well: https://launchpad.net/distros/ubuntu/+source/kdeutils/+bug/67521 simple workaround: save some passwords, at the end of your session rightclick on wallet, select 'close all wallets', logout and all the passwords you saved during the last session will be stored in your wallet. so you'll have to close it everytime you add a password... The workaround works, although it's not really convenient. Still, there's another anomaly: if a map for a site contains more keys than just a pair of username/password, storing a third key immediately erases from the wallet the username and password just stored. So in this case not even the workaround is any good. *** Bug 136895 has been marked as a duplicate of this bug. *** I can confirm this on Gentoo with kwalletmanager-3.5.5. Changes to the wallet are only saved when I either close the wallet manually, or when I logout cleanly. What this means is that in the event of a crash (X11 or kernel), power failure or something similar I will loose all passwords saved during that session. And because I rarely log out of the system, that could easily mean a month or two's worth of random passwords used once. (which means that my chance of remembering them is zero) Please, for all that's good and holy, fix kwallet to save the wallet file instantly whenever there's a change and to preferably keep 2-5 backup versions of each wallet automatically in case of a corruption. This bug is a real showstopper especially since the user only finds out about it after the passwords have been lost. It has already forced me to locally replace all the passwords in one remotely administered server. Status should probably be changed to "CONFIRMED" no ? *** This bug has been confirmed by popular vote. *** Confirmed on Kubuntu Edgy Eft. I have to go to a few sites and go through the "I forgot my password" procedure when I go home :(. Passwords are saved if I manually close the wallet, but not if I just log out/reboot without manually closing the wallet first. Note that I do not have any of the 3 auto-close wallet options enabled - maybe using the one that closes the wallet when all apps that use it are gone will help (as a work-around). Not tested that yet. I've same problem: http://bugs.kde.org/show_bug.cgi?id=139065 After rebooting KWallet 1.1 (3.5.5) (kubuntu dapper) has only 10 instead of 16 KMail passwords. Work around seems to work... (I've never tried to import any files) Created attachment 19320 [details]
sync kwallet changes immediately
There was a Debian user whose passwords weren't being saved, so I created this
patch to sync all changes to disk immediately after they are made (rather than
waiting for the wallet to close). This fixed his problem, but he then
reinstalled the previous version, and the problem didn't come back.
Anyway, is there anything wrong with writing the changes to disk right away?
Honestly I'm really tired of watching this thread. The problem is that kded is crashing or KDE is not logging out cleanly and therefore the passwords are not saving. If KWallet is set to auto-close, it will also save then. At this point I really don't care anymore because I don't see kded ever being fixed. Therefore the patch is fine with me if someone wants to apply it. -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/ Having a write cache for a store that is rarely modified makes no sense, especially if it contains such valuable data. IMHO the usability problem this causes takes first priority. I've too have lost passwords because of this 'bug' so I'd really like to see write-through become a permanent solution. The patch in attachment 19320 [details] works for me.
I agree with #12-15. Also consider the quite common case of users who *never* log out. Either on a desktop that is always on or on a laptop that is suspended in between uses this is quite normal use. Sessions will then end in only one way: with the occasional crash, that may happen, say, once a month. And so, all passwords be lost. Hence, no application should count on being able to save its state on exit, because graceful shutdowns may occur rarely if at all. Sorry for simply duping this but this is exactly the same problem as reported on kwalletmanager. It's fixed for 4.1 - wallets aren't saved immediately but after a delay of 5 seconds (like this merging/importing wallets doesn't create an overhead). *** This bug has been marked as a duplicate of 105752 *** No offense, but calling a critical bug fixed, because it doesn't occur in an API&ABI incompatible version is hardly what I'd describe as the Right Thing To Do(tm). For Pete's sake, there are hundreds of thousands of people out there depending on this functionality _in_ KDE-3.5, and you shrug them off with "works in 4.1"? This bug includes a patch, which fixes the problem in KDE-3.5 and also is the Right(tm) fix for KDE-4. (I mean, a 5 second delay for saving passwords because of an 'overhead', come on) Please do something about this in KDE-3.5, or at least have the decency to mark this as WONTFIX. (And in case you're wondering whether or not this is critical, this bug _eats_ _people's_ _passwords_.) |