Summary: | configure doesn't detect libqt-mt correctly in fedora/redhat 64bit | ||
---|---|---|---|
Product: | [I don't know] kde | Reporter: | Kerwin Khu <kerwin.khu> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | rdieter |
Priority: | NOR | ||
Version: | 3.5 | ||
Target Milestone: | --- | ||
Platform: | RedHat Enterprise Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
add default fedora/redhat qt locations, adding pkg-config support
add default fedora/redhat qt locations, adding pkg-config support (take 2) |
Description
Kerwin Khu
2006-10-27 11:17:01 UTC
CentOS includes /etc/profile.d/qt.sh which should properly set QTLIB env var for your platform. OK, looks like redhat hasn't fixed that yet... see also: "define QTINC/QTLIB in qt.sh/qt.csh": http://bugzilla.redhat.com/212722 I'll leave that to downstream, then. I'd really like this to get fixed properly, so fedora/redhat derivatives just work. In short I'd like to see at least: Index: acinclude.m4.in =================================================================== --- acinclude.m4.in (revision 745636) +++ acinclude.m4.in (working copy) @@ -1459,7 +1459,7 @@ qt_libdirs="" for dir in $kde_qt_dirs; do - qt_libdirs="$qt_libdirs $dir/lib${kdelibsuff} $dir" + qt_libdirs="$qt_libdirs $dir/lib${kdelibsuff} $dir/lib $dir" done qt_libdirs="$QTLIB $qt_libdirs /usr/X11R6/lib /usr/lib /usr/local/qt/lib $x_libraries" if test ! "$ac_qt_libraries" = "NO"; then It also would make sense to me to add pkgconfig support for detecting qt (and I'd be willing to work on that), if there are no objections. Created attachment 22631 [details]
add default fedora/redhat qt locations, adding pkg-config support
Seems I don't have sufficient mojo/Karma to commit this myself, reassigning back to default owner. OK I'll commit this patch; but I think I found a bug in it... + if (`$PKG_CONFIG --exists qt-mt`) ; then This opens a sub-shell and calls --exist in it, and only keeps the string output of it; I don't think this works. For proof: (`pkg-config --exists idontexist`) && echo ok shows ok. I think this should be simply: if $PKG_CONFIG --exists qt-mt; then no? Hmm... you may very well be right, dang, that's one conditional that I didn't test very well (ie, qt-mt.pc not existing). I just lifted similar code from elsewhere in acinclude.m4.in in the OpenEXR detection bits, so that's likely wrong too. Look for: if !(`$PKG_CONFIG --exists OpenEXR`) ; then :) SVN commit 750986 by dfaure: This was bogus indeed. CCBUG: 136377 M +2 -2 acinclude.m4.in WebSVN link: http://websvn.kde.org/?view=rev&revision=750986 Created attachment 22639 [details]
add default fedora/redhat qt locations, adding pkg-config support (take 2)
updated patch using better
if $PKG_CONFIG --exists ... ; then
contructs
SVN commit 751182 by dfaure: Committing patch by Rex Dieter: add default fedora/redhat qt locations, adding pkg-config support BUG: 136377 M +26 -2 acinclude.m4.in WebSVN link: http://websvn.kde.org/?view=rev&revision=751182 |