Bug 136372

Summary:	Outgoing messages history not updated on multiline pastes
Product:	[Applications] konversation	Reporter:	Philippe Cloutier <chealer>
Component:	general	Assignee:	Konversation Developers <konversation-devel>
Status:	VERIFIED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:

Description Philippe Cloutier 2006-10-27 04:08:31 UTC

Version:           1.0.1 (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Suppose I write the following email:

Hi Alice, do you know what? I use Thunderbird on one of my desktops but I
hate it because it automatically wraps lines, no matter what I do. See?
Use kmail!

and then I meet Alice on IRC. I want to send the following message:

Hey Alice. Did you get the urgent email I just sent you? It reads "Hi Alice, do you know what? I use Thunderbird on one of my desktops but I hate it because it automatically wraps lines, no matter what I do. See? Use kmail!"

Since I am on #konversation and don't want to annoy konversation developers, I want to send this message in a single line. But since I am copy-pasting a part of the text from Thunderbird, I get an Edit Multiline Paste dialog. I use the dialog only to eliminate newlines and add an ending quote, then send the message.

The bug is that if I press arrow up after that to browse the outgoing messages history, the string which appears is:

Hey Alice. Did you get the urgent email I just sent you? It reads "

but nothing else. So everything done after the paste is ignored.

Comment 1 Eike Hein 2006-10-27 14:26:46 UTC

SVN commit 599506 by hein:

Append the text actually sent as the result of a paste edit to the
input history, rather than the input line contents.
BUG:136372


 M  +1 -1      ircinput.cpp  


--- trunk/extragear/network/konversation/src/ircinput.cpp #599505:599506
@@ -447,7 +447,7 @@
               // signal pasted text
               emit textPasted(pasteText);
               // remember old line, in case the user does not paste eventually
-              addHistory(text());
+              addHistory(pasteText);
               // delete input text
               clear();
             }