Summary: | Crash when attempting to use Fit Polynomial plugin. | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | Duncan Hanson <duncan.hanson> |
Component: | general | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Duncan Hanson
2006-10-13 00:41:26 UTC
Trunk seems to work for me (?) cbn On Thursday 12 October 2006 18:41, Duncan Hanson wrote: [bugs.kde.org quoted mail] I can't reproduce with trunk either. I don't seem to have the problem in 1.3 (branch) either... Can't reproduce. Do you do the fit using the Data->New Menu, or using the Fit context menu item in the plot? The crash only occurs for me using the Data->New Plugin route. Duncan. On Monday 16 October 2006 09:09, Adam Treat wrote: [bugs.kde.org quoted mail] I see it. Thanks Duncan. This deadlock appears for all fit plugins created through the top-level menu OR the datamanager->new plugin manner. It seems to be caused by commit #576228. The commit log says 576228 was a fix for another deadlock. Removing this change fixes this bug, but I don't know what the other deadlock was about, so I'm loathe to revert. This won't be fixed in 1.3.1 and I'm hesitant to fix it in 1.3.x at all. This deadlock is the result of a fix for another deadlock. The reason for this mess is somewhat complicated. First, automatically adding scalars to the global list is an issue when we need to lock an object that we are providing while we are locked. It can deadlock with the update thread. The "fix" for this caused the regression referenced in this bug. The function it happened in doesn't even belong in KstPlugin. KstScalar's constructor is a mess already, especially with the locking argument, and adding another is not a good answer. I think we need to fix scalars properly. This is a Kst 1.4 item only. Why does it work from the 2dplot rmb, but not from the dialog? On Tuesday 17 October 2006 23:38, George Staikos wrote: [bugs.kde.org quoted mail] Different locking/nesting situation. Note: This is fixed in the hierarchy branch with commit #612802 Duncan, could you test this and confirm that the problem has been fixed. If so please mark this bug report as fixed. *** Bug has been marked as fixed ***. |