Bug 134225

Summary: user information face select window anomaly
Product: [Applications] systemsettings Reporter: FiNeX <finex>
Component: generalAssignee: Simon Edwards <simon>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Face browser error
patch, please test and add the next file as well
the .ui file which gos with previous patch

Description FiNeX 2006-09-17 19:20:25 UTC
Version:           0.2 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu11 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-7-generic

On the window opened by clicking the button for change the user image in the user information control panel, when an image is selected, the image is not focused, but it is selected because clicking the "OK" button the image is loaded to the configuration page.
Comment 1 FiNeX 2007-06-23 00:28:14 UTC
Actually, on KDE 3.5.7 the bug is no more present. (tested on kubuntu and on others distro).
Comment 2 FiNeX 2007-11-14 20:47:53 UTC
On the revision 736690 of KDE4, the bug is still present: you select the icon, and you can click ok, but the icon is not focused.
Comment 3 FiNeX 2007-11-14 20:52:13 UTC
Created attachment 22062 [details]
Face browser error

I've clicked on an icon, but it is not focused!!!!
Comment 4 Anne-Marie Mahfouf 2007-11-16 18:30:15 UTC
Created attachment 22094 [details]
patch, please test and add the next file as well

Put the dialog widget in a separate .ui file but kept Q3IconView (did not have
the guts to pport to QListView...)
Comment 5 Anne-Marie Mahfouf 2007-11-16 18:31:21 UTC
Created attachment 22095 [details]
the .ui file which gos with previous patch
Comment 6 FiNeX 2007-11-16 19:05:55 UTC
Just tried. It works correctly :-)
Comment 7 Anne-Marie Mahfouf 2007-11-16 20:11:28 UTC
The icon on the KPushButton is tiny in Oxygen style but is OK in other styles such as Plastique or Motif or Plastik.
Seems only in Oxygen that the pixmap stays tiny and as said in QAbstractButton API doc: "The icon's default size is defined by the GUI style, but can be adjusted by setting the iconSize property." it seems that Oxygen prevents it to be bigger.
Comment 8 Anne-Marie Mahfouf 2007-11-16 20:53:02 UTC
SVN commit 737619 by annma:

put GUI dialog in a separate .ui file and thus fixes the icon not being selected after the user clicks on it.
left Q3IconView (did not port to QListView) so to not introduce other bugs
on the KPushButton, the user icon is displayed, it's tiny in Oxygen style while it's the correct size in other styles: Oxygen bug?
BUG=134225


 M  +1 -1      CMakeLists.txt  
 M  +12 -34    chfacedlg.cpp  
 M  +5 -3      chfacedlg.h  
 A             faceDlg.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=737619