Bug 133173

Summary: server tab notification state is lost when adding channels to an existing server
Product: [Applications] konversation Reporter: Niek Beernink <n.beernink>
Component: generalAssignee: Konversation Developers <konversation-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Niek Beernink 2006-08-29 11:24:33 UTC 
Version:           1.0rc1 #3148 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu6 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-25-k7

How to reproduce:

I'll take irc.opera.com as an example but any server will do.

1. Open the server list by pressing F2, click "New..."
2. In the Network field, type "Opera".
3. In the servers group, click "Add..." and type "irc.opera.com" as the server, then click "Ok".
4. In the Auto Join Channels group, click "Add..." and type "#testabc" as the channel, then click "Ok".
5. Click "Ok" in the New Network Dialog and click "Connect".
6. Disable notifications for the server tab, by right-clicking on it and selecting "Enable Notifications"
7. Now close the server tab by right-clicking it and selecting close tab.
8. Open the Server List by pressing F2 and add another channel (for example #testdef) to the list in Auto Join Channels.
9. Close the Edit Network Dialog and Click Connect.
10. Notice how the server tab has notifications re-enabled.

The same thing does not happen to channels. Those notification states are remembered correctly.

Expected Behavior:

Notification state of the server tab is remembered when I add (or remove) new channels.
Comment 1 Eike Hein 2006-08-29 13:50:54 UTC 
SVN commit 578456 by hein:

Preserve status tab notifications state while editing networks.
BUG:133173


 M  +2 -0      servergroupdialog.cpp  
 M  +1 -1      servergroupdialog.h  


--- trunk/extragear/network/konversation/src/servergroupdialog.cpp #578455:578456
@@ -175,6 +175,7 @@
         m_id = settings->id();
         m_sortIndex = settings->sortIndex();
         m_expanded = settings->expanded();
+        m_enableNotifications = settings->enableNotifications();
         m_nameEdit->setText(settings->name());
         m_identityCBox->setCurrentText(settings->identity()->getName());
         m_commandEdit->setText(settings->connectCommands());
@@ -210,6 +211,7 @@
         settings->setServerList(m_serverList);
         settings->setChannelList(m_channelList);
         settings->setChannelHistory(m_channelHistory);
+        settings->setNotificationsEnabled(m_enableNotifications);
         settings->setExpanded(m_expanded);
 
         return settings;
--- trunk/extragear/network/konversation/src/servergroupdialog.h #578455:578456
@@ -76,7 +76,7 @@
             QToolButton* m_upChannelBtn;
             QToolButton* m_downChannelBtn;
             bool m_expanded;
-
+            bool m_enableNotifications;
             int m_id;
             int m_sortIndex;