Bug 133076

Summary:	questioning the need for mark history option
Product:	[Applications] amarok	Reporter:	baum-im-wald
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	sitter
Priority:	NOR
Version:	1.4-SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description baum-im-wald 2006-08-27 16:18:59 UTC

Version:           1.4-SVN (using KDE 3.5.3, Kubuntu Package 4:3.5.3-0ubuntu0.2 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-23-386

personally, i don't see a need for the "mark history" option in the dynamic playlist configuration. i always have it set to on because it looks better and makes it easier to see which items were already played and which weren't.

if there are people who need this option, keep it in, but as i don't see the use of it, i suggest removing it. comments?

Comment 1 Mark Kretschmann 2006-08-27 16:34:44 UTC

I agree. We could remove the option and have it permanently enabled.

Comment 2 Harald Sitter 2006-08-27 20:46:53 UTC

totally agree

Comment 3 Seb Ruiz 2006-08-31 02:40:09 UTC

SVN commit 579071 by seb:

* Remove the option to enable/disable history in dynamic mode. It is now on always.
* Disable "Played tracks to show" option if tracks are not removed from dynamic mode, when creating a new dynamic playlist
* Reduce the minimum available tracks to show to 0.
* The beginnings of restoring purged items for podcasts (got caught up in the commit).

BUG: 133078
BUG: 133076
BUG: 131223



 M  +2 -0      ChangeLog  
 M  +0 -3      src/dynamicmode.cpp  
 M  +0 -3      src/dynamicmode.h  
 M  +25 -35    src/newdynamic.ui  
 M  +24 -30    src/playlist.cpp  
 M  +1 -1      src/playlist.h  
 M  +0 -4      src/playlistbrowser.cpp  
 M  +50 -11    src/playlistbrowseritem.cpp  
 M  +1 -0      src/playlistbrowseritem.h  
 M  +0 -2      src/playlistselection.cpp