Summary: | [regression] [testcase] Textarea loses content when changing display style | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Diogo Galvão <diogo86> |
Component: | khtml | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | bss, gentakojima, maksim, micha |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | attaching testcase for convenience |
Description
Diogo Galvão
2006-08-23 09:07:53 UTC
argh. Serious regression. Created attachment 17468 [details]
attaching testcase for convenience
I have a feeling it may be my fault, and it's likely related to some of the other syncing bugs... Ugh. The troublemaker is the bizarre RenderTextArea::close call. I have no idea as to why it's there... Will annotate.. .. And that call seems to be a workaround for some QTextEdit bug, which causes us to not set initial value right.. investigating also reported in Debian BTS at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=428068 for 3.5.7 with an example of code SVN commit 712622 by orlovich: Rework how we sync textarea contents between the DOM and the Renderer, fixing multiple bugs (losing contents on display:none, the can't-do-anything-with-selection- in-wordpress bug). This also improves compatibility with IE on handling of innerText somewhat, and that with other browsers in how we handle changes to the default value/child nodes. Unfortunately, no one does it the same way, so I chose to follow Safari since its behavior makes the most sense to me. More specifically: 1. Simplify the syncing logic by making the renderer always be definitive when it exists. 2. Change how we initialize from the defaultValue --- instead of doing it in the renderer's close (which is what causes the disappearing text bug), we update value to defaultValue when the children change. That also makes innerText work sensibly on textareas. BUG: 132844 BUG: 120607 BUG: 141457 M +27 -10 html/html_formimpl.cpp M +1 -1 html/html_formimpl.h M +16 -22 rendering/render_form.cpp M +2 -1 rendering/render_form.h WebSVN link: http://websvn.kde.org/?view=rev&revision=712622 *** Bug 151017 has been marked as a duplicate of this bug. *** Which release will have this bugfix? I still get the same error in kde-3.5.8. 4.0.0 |