Bug 131776

Summary:	"Set Custom Cover" file select dialog no longer starts in same directory as audio file
Product:	[Applications] amarok	Reporter:	Dave Baker <davidbaker84>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.4.2-beta1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Fix for described issue This patch fixes the select custom cover dialog starting directory for compilations

Description Dave Baker 2006-08-03 14:49:33 UTC

Version:           1.4.2-beta1 (using KDE KDE 3.5.3)
Installed from:    Gentoo Packages
OS:                Linux

This appears to be the same issue as bug 97346, but is now broken again in 1.4.2-beta1, and I'm not allowed to re-open the same bug.

When right-clicking on the cover image in the 'context' tab of the sidebar, and selecting 'Set Custom Cover', the file selection dialog should start in the directory in which the file whose cover is being set resides.

Comment 1 Dave Baker 2006-08-30 02:32:45 UTC

Created attachment 17564 [details]
Fix for described issue

The problem only exists, at least in SVN as of 30/08/06, for compilations. The
problem is that CollectionDB::albumTracks always looks for tracks by the same
artists, which clearly won't work for compilations. Fix: it's unnecessary to
filter by the artist when selecting by album id anyway.

Comment 2 Alexandre Oliveira 2006-11-05 20:31:34 UTC

Works for me on svn.

Comment 3 Tobias Knieper 2006-11-05 22:40:06 UTC

Alexandre, did you use a track in a compilation as stated in the report? This seems not to work (revision 602388).

Comment 4 Alexandre Oliveira 2006-11-08 15:54:10 UTC

reading reports in a hurry is quite bad

Comment 5 Tobias Knieper 2006-12-14 21:40:35 UTC

Created attachment 18934 [details]
This patch fixes the select custom cover dialog starting directory for compilations

This patch fixes the select custom cover dialog starting directory for
compilations. In order to get this to work I refactored the albumTracks(). I
tested the five cases in which albumTracks() gets called and everything seems
to work fine. This fixes bug #131776.

Comment 6 Tobias Knieper 2007-01-08 21:11:02 UTC

SVN commit 621430 by tknieper:

fixed the select custom cover dialog starting directory for 
compilations. updated ChangeLog.
BUG: 131776



 M  +2 -0      ChangeLog  


--- trunk/extragear/multimedia/amarok/ChangeLog #621429:621430
@@ -45,6 +45,8 @@
       you move and rename them.
 
   CHANGES:
+    * The select custom cover dialog no longer starts in the wrong directory 
+      for compilations. (BR 131776)
     * Support for cue files not matching audio files' name. Patch by Dawid
       Wróbel <dawid@klej.net>. (BR 128046)
     * Script Manager now remembers if categories were open or closed.