Bug 127907

Summary:	Restoration filter (CIMG) does not function properly
Product:	[Applications] krita	Reporter:	Matthias Wieser <mwieser>
Component:	Filters	Assignee:	Halla Rempt <halla>
Status:	RESOLVED INTENTIONAL
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Original image Krita plugin: standard settings, but 5 iterations Krita plugin: standard settings Result of the new cimg 1.13 stand alone GREYCstoration tool (default settings)

Description Matthias Wieser 2006-05-23 22:51:43 UTC

Version:           1.5.1 (using KDE KDE 3.5.2)
Installed from:    SuSE RPMs
OS:                Linux

I'm using Krita 1.5.1 and it's Restoration filter.

Two things:
1. There is a new version of cimg available with much improved (speed, quality) restoration algorithms.
2. There is a bug which leads to 45° "motion blur" of the resoration filter. (see attachement) Increasing the iterations (e.g. "5") makes the problem more visible.

Comment 1 Matthias Wieser 2006-05-23 22:54:24 UTC

Created attachment 16248 [details]
Original image

image source:
http://www.greyc.ensicaen.fr/~dtschump/greycstoration/guide.html

Comment 2 Matthias Wieser 2006-05-23 22:55:28 UTC

Created attachment 16249 [details]
Krita plugin: standard settings, but 5 iterations

Comment 3 Matthias Wieser 2006-05-23 22:58:42 UTC

Created attachment 16250 [details]
Krita plugin: standard settings

even with only one iteration a slight 45° "motion blur" effect is visible.

Comment 4 Matthias Wieser 2006-05-23 23:00:24 UTC

Created attachment 16251 [details]
Result of the new cimg 1.13 stand alone GREYCstoration tool (default settings)

This quality (and even better, see
http://www.greyc.ensicaen.fr/~dtschump/greycstoration/guide.html ) could be
achieved with the new cimg 1.13 lib.

Comment 5 Cyrille Berger 2006-07-17 18:26:48 UTC

SVN commit 563447 by berger:

update the version of CImg
CCBUG:127907


 M  +6909 -1627 CImg.h   [POSSIBLY UNSAFE: scanf,system]

Comment 6 Cyrille Berger 2006-07-17 18:34:41 UTC

as for the bug, the code of this plugins is too horible for me :( (I will change it to work on 16bit channels, but that's all I can do)

Comment 7 Halla Rempt 2008-10-26 11:13:12 UTC

Moved to playground since it's a high-maintenance filter and none of us have got time for it,