Bug 126598

Summary:	stop after track menu function missing
Product:	[Applications] amarok	Reporter:	ramnath_r_iyer
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:

Description ramnath_r_iyer 2006-05-02 12:26:37 UTC

Version:           1.4 beta 3 (using KDE KDE 3.5.1)
Installed from:    Fedora RPMs
Compiler:          gcc 4.1.0 
OS:                Linux

There used to be a "Stop after this track" option in the right-click popup menu for any track. This menu option seems to be missing in this version of amaroK although I can still use the global shortcut Ctrl-Alt-V to do this.

Comment 1 ramnath_r_iyer 2006-05-02 12:39:53 UTC

A clarification: The menu is available when Random mode is off, but it is useful even otherwise - there's no reason why it should be dropped.

Comment 2 Gábor Lehel 2006-05-02 17:18:10 UTC

It's there for tracks which are going to be played in the future, e.g.
the current one, queued tracks, and so. It makes little sense to set
it on just any track with random mode on...

--
Work is punishment for failing to procrastinate effectively.

Comment 3 ramnath_r_iyer 2006-07-12 07:52:03 UTC

There are two ways of enabling 'Stop after this track' for any non-queued track in Random mode.

(1) Press Ctrl-Alt-V, the shortcut
(2) Queue the track, enable 'Stop after this track' and then dequeue it

I think for the sake of uniformity, these methods of enabling it should be removed, or else 'Stop playing after track' menu item should be added to all tracks, irrespective of whether they are queued or not.

If no one agrees, then I'll close this bug. :)

Comment 4 Martin Aumueller 2006-10-25 22:29:42 UTC

SVN commit 599116 by aumuell:

make playlist context menu tall enough for the side pixmap by always showing the 'stop playing after this track' entry
BUG: 126598


 M  +2 -8      playlist.cpp  


--- trunk/extragear/multimedia/amarok/src/playlist.cpp #599115:599116
@@ -3947,7 +3947,7 @@
         popup.insertItem( SmallIconSet( Amarok::icon( "play" ) ), isCurrent && isPlaying
                 ? i18n( "&Restart" )
                 : i18n( "&Play" ), PLAY );
-    if( isCurrent && !isLastFm )
+    if( isCurrent && !isLastFm && isPlaying )
         Amarok::actionCollection()->action( "pause" )->plug( &popup );
 
     // Begin queue entry logic
@@ -3991,13 +3991,7 @@
                 break;
             }
 
-    if( itemCount == 1 && ( item->isCurrent() || item->isQueued() || m_stopAfterTrack == item ||
-                            ( !AmarokConfig::randomMode() && ( Amarok::repeatPlaylist() || afterCurrent ) ) ||
-                            ( Amarok::entireAlbums() && m_currentTrack &&
-                              item->m_album == m_currentTrack->m_album &&
-                              ( Amarok::repeatAlbum() || ( ( !item->track() && afterCurrent ) ||
-                                                             item->track() > m_currentTrack->track() ) ) ) ) )
-                                                                                     //looks like fucking LISP
+    if( itemCount == 1 )
     {
         Amarok::actionCollection()->action( "stop_after" )->plug( &popup );
         dynamic_cast<KToggleAction *>( Amarok::actionCollection()->action( "stop_after" ) )->setChecked( m_stopAfterTrack == item );