Bug 124638

Summary:	Folder icon doesn't use system theme
Product:	[Applications] kopete	Reporter:	Adam Porter <adam>
Component:	Main Application	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ana
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:

Description Adam Porter 2006-03-31 15:06:34 UTC

Version:           0.12-beta2 (using KDE KDE 3.5.1)
Installed from:    Debian testing/unstable Packages

I just compiled and installed Kopete 0.12-beta2.  I like it, but I noticed that the folder icons in the buddy list are green, instead of using my KDE icon theme's folder icon, like Kopete 0.11 does.  Is this a bug or a new intended feature?  I prefer using my KDE theme's folder icon.

Comment 1 Olivier Goffart 2006-03-31 16:15:00 UTC

It was intentional, but i don't remember the reason

Comment 2 Matt Rogers 2006-04-09 01:52:07 UTC

kopete 0.11 does not use the icon theme's folder icon so it seems debian has patched it.

Comment 3 Adam Porter 2006-04-14 05:23:32 UTC

Yes, you're right:

$ less debian/patches/16_kopete_green_folder.diff
--- kdenetwork-orig/kopete/kopete/kopetewindow.cpp
+++ kdenetwork-patched/kopete/kopete/kopetewindow.cpp
@@ -245,7 +245,7 @@

        actionShowOffliners = new KToggleAction( i18n( "Show Offline &Users" ), "viewmag", CTRL + Key_U,
                        this, SLOT( slotToggleShowOffliners() ), actionCollection(), "settings_show_offliners" );
-       actionShowEmptyGroups = new KToggleAction( i18n( "Show Empty &Groups" ), "folder_green", CTRL + Key_G,
+       actionShowEmptyGroups = new KToggleAction( i18n( "Show Empty &Groups" ), "folder", CTRL + Key_G,
                        this, SLOT( slotToggleShowEmptyGroups() ), actionCollection(), "settings_show_empty_groups" );

        actionShowOffliners->setCheckedState(i18n("Hide Offline &Users"));
--- kdenetwork-orig/kopete/kopete/contactlist/kopetegroupviewitem.h
+++ kdenetwork-patched/kopete/kopete/contactlist/kopetegroupviewitem.h
@@ -21,8 +21,8 @@
 #include "kopetelistviewitem.h"
 #include <qpixmap.h>

-#define KOPETE_GROUP_DEFAULT_OPEN_ICON "folder_green_open"
-#define KOPETE_GROUP_DEFAULT_CLOSED_ICON "folder_green"
+#define KOPETE_GROUP_DEFAULT_OPEN_ICON "folder_open"
+#define KOPETE_GROUP_DEFAULT_CLOSED_ICON "folder"

 namespace Kopete
 {

Could this please be made the default?

Comment 4 Ollivier-Lapeyre Johann 2006-04-14 17:41:18 UTC

I vote yes, should i commit it?
I vote yes, should i commit it?<br>

Comment 5 Matt Rogers 2006-04-14 18:21:20 UTC

please commit

Comment 6 Ollivier-Lapeyre Johann 2006-04-16 17:13:28 UTC

*** Bug has been marked as fixed ***.