Bug 123548

Summary:	'Apply' button is always enabled in 'Filter rules' dialogue
Product:	[Applications] kmail	Reporter:	Hugh Warrington <hughwarrington>
Component:	filtering	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	a.m.p.boelens, bjoern, rjohnson
Priority:	NOR	Keywords:	junior-jobs
Version:	1.10.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Hugh Warrington 2006-03-13 14:07:35 UTC

Version:           1.9 (using KDE 3.5.0, compiled sources)
Compiler:          gcc version 3.4.3
OS:                Linux (i686) release 2.6.15.4-0

It seems to be a convention that 'Apply' buttons are only enabled if clicking them has an effect. The 'Apply' button in Settings->Configure Filters... is always enabled, even after it has been clicked.

Comment 1 Thomas McGuire 2007-06-09 14:22:04 UTC

*** Bug 146569 has been marked as a duplicate of this bug. ***

Comment 2 Arnout Boelens 2008-08-07 20:31:53 UTC

This bug is still present in 1.10.

Comment 3 Björn Ruberg 2009-12-25 18:48:01 UTC

Still in KDE 4.3

Comment 4 András Manţia 2010-12-10 12:44:09 UTC

SVN commit 1205188 by amantia:

Fix the Apply button behaviour in the Configure Filters dialog. Patch by George Metaxas.

BUG: 123548

 M  +62 -4     kmail/kmfilterdlg.cpp  
 M  +19 -0     kmail/kmfilterdlg.h  
 M  +123 -76   mailcommon/filteraction.cpp  
 M  +29 -11    mailcommon/filteraction.h  
 M  +11 -2     mailcommon/filteractionwidget.cpp  
 M  +6 -0      mailcommon/filteractionwidget.h  
 M  +24 -1     mailcommon/searchpatternedit.cpp  
 M  +4 -2      mailcommon/searchpatternedit.h  
 M  +1 -0      mailcommon/soundtestwidget.cpp  
 M  +6 -0      mailcommon/soundtestwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1205188

Comment 5 Hugh Warrington 2010-12-10 15:48:46 UTC

Nice one! Good things come to those who wait.