Summary: | rms scalar is wrong | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | Enzo Pascale <enzo> |
Component: | general | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Enzo Pascale
2006-02-08 01:10:52 UTC
SVN commit 506997 by staikos: correct RMS Looks like a refactoring gone wrong... Ok for 1.2.0 and trunk? CCBUG: 121566 M +2 -2 kstvector.cpp --- branches/kst/hfi_calib/kst/kst/kstvector.cpp #506996:506997 @@ -195,9 +195,9 @@ if (_nsum >= 2) { double sum = _scalars["sum"]->value(); - double sumsq; + double sumsq = _scalars["sumsquared"]->value(); _scalars["mean"]->setValue(_mean = sum/double(_nsum)); - _scalars["sigma"]->setValue(sumsq = sqrt((_scalars["sumsquared"]->value() - sum * sum / double(_nsum)) / double(_nsum-1))); + _scalars["sigma"]->setValue(sqrt((sumsq - sum * sum / double(_nsum)) / double(_nsum-1))); _scalars["rms"]->setValue(sqrt(sumsq/double(_nsum))); } else { _scalars["sigma"]->setValue(_max - _min); Yes. cbn On February 7, 2006 08:33 pm, George Staikos wrote: [bugs.kde.org quoted mail] > correct RMS
> Looks like a refactoring gone wrong... Ok for 1.2.0 and trunk?
> CCBUG: 121566
I don't know if I'm in the "reviewer's list", but looks good to me.
SVN commit 506998 by staikos: fix RMS computation BUG: 121566 M +2 -2 kstvector.cpp --- trunk/extragear/graphics/kst/kst/kstvector.cpp #506997:506998 @@ -195,9 +195,9 @@ if (_nsum >= 2) { double sum = _scalars["sum"]->value(); - double sumsq; + double sumsq = _scalars["sumsquared"]->value(); _scalars["mean"]->setValue(_mean = sum/double(_nsum)); - _scalars["sigma"]->setValue(sumsq = sqrt((_scalars["sumsquared"]->value() - sum * sum / double(_nsum)) / double(_nsum-1))); + _scalars["sigma"]->setValue(sqrt((sumsq - sum * sum / double(_nsum)) / double(_nsum-1))); _scalars["rms"]->setValue(sqrt(sumsq/double(_nsum))); } else { _scalars["sigma"]->setValue(_max - _min); |