Bug 118324

Summary: "close tab" button appears, even when no tabs are available to close
Product: [Applications] akregator Reporter: Kae Verens <kae>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: dev, kae
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:

Description Kae Verens 2005-12-14 17:06:52 UTC
Version:            (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources

the button to close a tab appears even if no tabs are available that can be closed
Comment 1 Frank Osterfeld 2005-12-14 17:13:32 UTC
Right, but it is disabled (greyed out), isn't it?
Comment 2 Kae Verens 2005-12-14 19:14:01 UTC
Frank Osterfeld wrote:

>------- Additional Comments From frank.osterfeld kdemail net  2005-12-14 17:13 -------
>Right, but it is disabled (greyed out), isn't it?
>  
>

no. anyway, would it not be better to remove it completly (or hide it) ?

or even copy the Konqueror behaviour, which is that when there is only 
one tabbed window, it is promoted to a main window (I don't know the 
terminology).

Kae
Comment 3 Tanja Schulte 2006-02-19 23:07:54 UTC
>  that when there is only one tabbed window, it is promoted to a main window

And the button hopped along happily... I don't like moving buttons. They should stay at one place.

But apart from that I don't know exactly which button is meant. Do you mean the close tab button at the right side of the konqueror window, the counterpart to the new tab button on the left side? I use KDE 3.5.1 and both are only visible when there are tabs. 
Comment 4 Tanja Schulte 2006-02-19 23:16:36 UTC
I'm sorry, I haven't seen this report is for akregator. I opened it out of a search for konqueror and tabs. Now I guess I know what you mean and it is the button I thought it could be. In KDE 3.5.1 it is greyed out when there is only one tab. But I also would prefer to have *no* tab bar shown when there are no tabs. Please hide the tab bar in akregator when there is only one sub-window. Not doing it is inconsistent behaviour because konqueror does it (option). Then there wouldn't be a close tab button at the right window side with only one tab open and everyone would be content :)
Comment 5 Teemu Rytilahti 2006-03-29 03:29:50 UTC
Frank, how about following the Konqueror's behaviour with this one too?
Comment 6 Frank Osterfeld 2006-09-04 00:44:10 UTC
Yes, if the Trolls implement nice hiding of the tabwidget when only one tab exists for Qt 4.2, we can add this for KDE4. Right now there is no good way to get rid of the frame around the tab widget.
However, I won't consider this as a bug but as a wishlist item.
Comment 7 Frank Osterfeld 2006-09-04 01:58:11 UTC
*** Bug 122120 has been marked as a duplicate of this bug. ***
Comment 8 Frank Osterfeld 2007-11-25 22:25:09 UTC
SVN commit 741559 by osterfeld:

hide tabbar when only one tab is there. sweet.
minor cleanup
BUG:118324


 M  +39 -15    tabwidget.cpp  
 M  +8 -6      tabwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=741559
Comment 9 Kae Verens 2007-11-26 09:49:48 UTC
thanks Frank!