Bug 117482

Summary:	Changing data range with kbd changes mouse from create mode to layout mode
Product:	[Applications] kst	Reporter:	Netterfield <netterfield>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Netterfield 2005-12-02 02:33:31 UTC

Version:           1.2.0_devel (using KDE 3.4.1, Gentoo)
Compiler:          gcc version 3.3.5-20050130 (Gentoo 3.3.5.20050130-r1, ssp-3.3.5.20050130-1, pie-8.7.7.1)
OS:                Linux (i686) release 2.6.9-gentoo-r6

Create a plot of a subset nsamp of a data source.
Go into eg, labelMode (or line mode, etc).
It works.

Now hit ctrl-right to advance the data 1 screen.
Notice that you are now in layout mode (?!) though the toolbar indicates you are still in labelMode.

If you change data range with the toolbar or with the change data range dialog, this badness doesn't happen.

Comment 1 Andrew Walker 2005-12-02 02:52:20 UTC

Not really in layout mode as the context menu is not for layout mode. It seems that the mouse handler is falling through to layout mode somewhere.

Comment 2 George Staikos 2005-12-02 18:38:18 UTC

  The problem is most likely that KstViewWidget was not updated to deal with 
the new view modes.  That is, it doesn't deal with Create or Label modes.

Comment 3 George Staikos 2005-12-02 18:45:26 UTC

SVN commit 485048 by staikos:

Stay in the right mouse mode on key press
BUG: 117482


 M  +1 -2      kstviewwidget.cpp  


--- trunk/extragear/graphics/kst/kst/kstviewwidget.cpp #485047:485048
@@ -463,8 +463,7 @@
       vo->keyPressEvent(this, e);
     }
     return;
-  } else if (_view->viewMode() != KstTopLevelView::DisplayMode &&
-             _view->viewMode() != KstTopLevelView::Unknown) {
+  } else if (_view->viewMode() == KstTopLevelView::LayoutMode) {
     ButtonState s = e->stateAfter();
     if (e->key() == Qt::Key_Escape) {
       _view->cancelMouseOperations();