Summary: | [patch] - major new functionality | ||
---|---|---|---|
Product: | superkaramba | Reporter: | Luke Kenneth Casson Leighton <lkcl> |
Component: | general | Assignee: | Ryan Nickell <p0z3r> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | jetchko.jekov |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
new functionality, extra files
update to enhanced functionality patch updated patch sub-theme (stop autoloading) and unique naming. sub-theme (stop autoloading) and unique naming and kpopup updated patch |
Description
Luke Kenneth Casson Leighton
2005-11-18 12:41:02 UTC
Created attachment 13532 [details]
new functionality, extra files
contains a patch file plus the missing files that i couldn't get svn to include
with a svn diff command.
Created attachment 13539 [details]
update to enhanced functionality patch
update. removed duplicate functionality (pythonIface-related).
merged KWindow stuff into karamba class, instead of deriving.
bit messy, but it works.
updated comments in src/misc_python.h.
added "disable/enable management popup" function, which works
added "call management popup" function which locks up XServer-Xorg!!!!
Created attachment 14259 [details]
updated patch
missed couple of files.
Created attachment 14268 [details]
sub-theme (stop autoloading) and unique naming.
this is an ADDITIONAL patch that sorts out some
ussies with theme loading.
1) sub-themes opened with openNamedTheme can be excluded
from the "OpenThemes" functionality which is that superkaramba
auto-starts themes when it's started up
2) if a theme with a particular pretty name already
exists, the theme is _not_ loaded a second time.
if you want multiple themes under the same name (unique doesn't matter)
then use openTheme not openNamedTheme.
Created attachment 14269 [details]
sub-theme (stop autoloading) and unique naming and kpopup
also fixed problem in management popup which locked
up xorg until i killed superkaramba.
use kpop->popup instead of kpop->exec().
Created attachment 14270 [details]
updated patch
updated to include the sub-theme stuff and unique naming etc.
reason: damn invonvenient for anyone looking at this stuff
to have to apply two patches.
the separate patch is for p0z3r who is in the middle of wading
through this stuff...
SVN commit 499776 by nickell: BUG:120262 - itemDropped callback now has x/y cooridinates BUG:116618 - Many new functions added: callTheme - Pass a string to another theme changeInterval - Change the refresh interval of the theme createServiceClickArea - Create a Service-named Click Area Sensor getIncomingData - Get incoming data passed from another theme getPrettyThemeName - Get the pretty name of the theme getServiceGroups - Get KDE Service Groups getSystraySize - Get the size of the Systray getUpdateTime - Get last updated time managementPopup - Activates the Management Popup menu (i.e. SK right click config menu) openNamedTheme - Open a new theme giving it a new name removeClickArea - Remove a Click Area Sensor run - Execute a command with KRun setIncomingData - Set incoming data passed in another theme setUpdateTime - Set last updated time setWantRightButton - Set to 1 to deactivate management popups (i.e. SK right click config menu) setWidgetOnTop - changes 'on top' status Patch reviewed by Matt Rogers. M +7 -1 AUTHORS M +16 -16 src/Makefile.am M +32 -12 src/clickarea.cpp [POSSIBLY UNSAFE: KRun::runCommand] M +4 -0 src/clickarea.h M +3 -0 src/dcopinterface.h M +1 -0 src/imagelabel_python.cpp M +97 -12 src/karamba.cpp M +40 -4 src/karamba.h M +53 -5 src/karamba_python.cpp M +3 -2 src/karamba_python.h M +20 -0 src/karambaapp.cpp M +1 -0 src/karambaapp.h M +29 -2 src/karambainterface.cpp M +3 -0 src/karambainterface.h M +2 -0 src/karambasessionmanaged.cpp M +1 -0 src/main.cpp M +5 -0 src/meter.cpp M +4 -0 src/meter.h M +270 -3 src/misc_python.cpp [UTF-8 ENCODING PROBLEMS] M +239 -4 src/misc_python.h [UTF-8 ENCODING PROBLEMS] M +4 -0 src/systemtray.cpp M +1 -0 src/systemtray.h M +22 -0 src/systray_python.cpp M +1 -0 src/systray_python.h M +20 -0 src/widget_python.cpp M +1 -0 src/widget_python.h I don't if here is right place to post that bug, but this patch introduces following errors on my x86_64 platform: /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp: In function 'long int removeClickArea(long int, long int)': /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp:322: error: cast from 'ClickArea*' to 'int' loses precision /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp: In function 'long int createServiceClickArea(long int, long int, long int, long int, long int, char*, char*, char*)': /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp:341: error: cast from 'ClickArea*' to 'int' loses precision /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp: In function 'long int callTheme(long int, char*, char*)': /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp:397: error: cast from 'karamba*' to 'int' loses precision /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp: In function 'long int setIncomingData(long int, char*, char*)': /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp:407: error: cast from 'karamba*' to 'int' loses precision /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp: In function 'long int openNamedTheme(char*, char*, bool)': /var/tmp/portage/superkaramba-7/work/branches/KDE/3.5/kdeutils/superkaramba/src/misc_python.cpp:446: error: cast from 'karamba*' to 'int' loses precision Build environment: default-linux/amd64/2005.1, gcc-4.1.0-beta20060113, glibc-2.3.6-r2, 2.6.15-gentoo x86_64) CHOST="x86_64-pc-linux-gnu" CFLAGS="-O2 -march=nocona -mtune=nocona -pipe -O2 -fno-ident" CXXFLAGS="-O2 -march=nocona -mtune=nocona -pipe -O2 -fno-ident -fvisibility-inlines-hidden -ffriend-injection" There were some compile fixes submitted this morning. Can you update and report back? Yes, it compiles & works now, thanks. compiles fine. On Fri, Jan 20, 2006 at 02:38:56PM -0000, Ryan Nickell wrote: [bugs.kde.org quoted mail] |