Bug 113805

Summary:	Image contextual menu "Set as Tag Thumbnail" in "Dates" view and "Searches" view ?
Product:	[Applications] digikam	Reporter:	Tung NGUYEN <ntung>
Component:	Usability-Menus	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	CLOSED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version:	0.8.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	8.3.0

Description Tung NGUYEN 2005-10-03 22:03:12 UTC

Version:           0.8.0-beta2 (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

in "Dates" view and "Searches" view (left sidebar), photos have a contextual menu "Set as Tag Thumbnail" but it does nothing (perhaps, the correct menu names are "Set as Date Thumbnail" and "Set as Search Thumbnail" in order to set a thumnail for the corresponding date or search?).

Comment 1 Renchi Raju 2005-10-04 10:25:45 UTC

SVN commit 467065 by pahlibar:

disable the "set as XX thumbnail" in the non-albums/tags
view

BUGS: 113805


 M  +7 -4      albumiconview.cpp  


--- trunk/extragear/graphics/digikam/digikam/albumiconview.cpp #467064:467065
@@ -444,10 +444,13 @@
     popmenu.insertItem(SmallIcon("exifinfo"),
                        i18n("Properties"), 14);
 
-    if( d->currentAlbum && d->currentAlbum->type() == Album::PHYSICAL )
-        popmenu.insertItem(i18n("Set as Album Thumbnail"), 17);
-    else
-        popmenu.insertItem(i18n("Set as Tag Thumbnail"), 17);
+    if (d->currentAlbum)
+    {
+        if (d->currentAlbum->type() == Album::PHYSICAL )
+            popmenu.insertItem(i18n("Set as Album Thumbnail"), 17);
+        else if (d->currentAlbum->type() == Album::TAG )
+            popmenu.insertItem(i18n("Set as Tag Thumbnail"), 17);
+    }
 
     popmenu.insertSeparator();

Comment 2 Tung NGUYEN 2005-10-07 13:24:13 UTC

I have tested this bug fix with the lastest SVN, "set as XX thumbnail" is now removed in the "Dates" view and "Searches" view.

Thank you.

Comment 3 caulier.gilles 2005-10-07 13:27:14 UTC

Fixed by Renchi. Closed.